-
Notifications
You must be signed in to change notification settings - Fork 13k
refactor: remove LoginPresence from Meteor startup
#35787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #35787 +/- ##
===========================================
+ Coverage 60.97% 61.01% +0.04%
===========================================
Files 2951 2952 +1
Lines 70291 70295 +4
Branches 16133 16134 +1
===========================================
+ Hits 42860 42891 +31
+ Misses 24483 24457 -26
+ Partials 2948 2947 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
5974079 to
4cdd21f
Compare
4cdd21f to
0c1b39f
Compare
0c1b39f to
32983f7
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
287ecf5 to
0f71e18
Compare
0f71e18 to
efc353f
Compare
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
ARCH-1546
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
This pull request refactors the Rocket.Chat codebase by removing
LoginPresencefrom the Meteor startup process. Key changes include:These changes aim to improve the handling of user presence and activity detection, optimizing the application's responsiveness and connection management.