Skip to content

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Apr 11, 2025

ARCH-1546

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments


This pull request refactors the Rocket.Chat codebase by removing LoginPresence from the Meteor startup process. Key changes include:

  1. New Hooks:
    • useIdleConnection: Added to manage server connection status based on user activity, particularly for handling anonymous user disconnections and reconnections.

These changes aim to improve the handling of user presence and activity detection, optimizing the application's responsiveness and connection management.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 11, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2025

⚠️ No Changeset found

Latest commit: efc353f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35787/

Built to branch gh-pages at 2025-04-16 15:38 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 12 lines in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (8715b7e) to head (efc353f).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35787      +/-   ##
===========================================
+ Coverage    60.97%   61.01%   +0.04%     
===========================================
  Files         2951     2952       +1     
  Lines        70291    70295       +4     
  Branches     16133    16134       +1     
===========================================
+ Hits         42860    42891      +31     
+ Misses       24483    24457      -26     
+ Partials      2948     2947       -1     
Flag Coverage Δ
e2e 57.74% <71.42%> (+0.08%) ⬆️
unit 75.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti added this to the 7.6.0 milestone Apr 11, 2025
@juliajforesti juliajforesti force-pushed the refactor/login-presence branch 2 times, most recently from 5974079 to 4cdd21f Compare April 11, 2025 20:46
@ggazzo ggazzo force-pushed the refactor/login-presence branch from 4cdd21f to 0c1b39f Compare April 11, 2025 21:56
@juliajforesti juliajforesti force-pushed the refactor/login-presence branch from 0c1b39f to 32983f7 Compare April 14, 2025 15:00
@juliajforesti juliajforesti marked this pull request as ready for review April 15, 2025 12:37
@juliajforesti juliajforesti requested a review from a team as a code owner April 15, 2025 12:37
@juliajforesti juliajforesti marked this pull request as draft April 15, 2025 18:23
@kody-ai

This comment was marked as duplicate.

@juliajforesti juliajforesti force-pushed the refactor/login-presence branch from 287ecf5 to 0f71e18 Compare April 16, 2025 13:19
@juliajforesti juliajforesti force-pushed the refactor/login-presence branch from 0f71e18 to efc353f Compare April 16, 2025 15:25
@kody-ai
Copy link

kody-ai bot commented Apr 16, 2025

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

@RocketChat RocketChat deleted a comment from kody-ai bot Apr 16, 2025
@RocketChat RocketChat deleted a comment from kody-ai bot Apr 16, 2025
@RocketChat RocketChat deleted a comment from kody-ai bot Apr 16, 2025
@juliajforesti juliajforesti marked this pull request as ready for review April 16, 2025 18:54
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 16, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 16, 2025
@ggazzo ggazzo merged commit 5730ebf into develop Apr 16, 2025
51 checks passed
@ggazzo ggazzo deleted the refactor/login-presence branch April 16, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants