-
Notifications
You must be signed in to change notification settings - Fork 13k
regression: fix apps logs expire as undefined
#35774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
undefined`undefined
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35774 +/- ##
===========================================
- Coverage 59.64% 59.60% -0.04%
===========================================
Files 2832 2832
Lines 68313 68350 +37
Branches 15129 15145 +16
===========================================
- Hits 40747 40742 -5
- Misses 24960 25000 +40
- Partials 2606 2608 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Due to how TS works, the property default value defined in the class' constructor is actually after calling
super(), so whenmodelIndexes()is called fromBaseRawthe value ofthis.expireAfterSecondsis stillundefined.Issue(s)
introduced by #35497
Steps to test or reproduce
Further comments