Skip to content

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Apr 10, 2025

Proposed changes (including videos or screenshots)

Due to how TS works, the property default value defined in the class' constructor is actually after calling super(), so when modelIndexes() is called from BaseRaw the value of this.expireAfterSeconds is still undefined.

Issue(s)

introduced by #35497

Steps to test or reproduce

Further comments

(STDERR) Some indexes for collection 'rocketchat_apps_logs' could not be created:
(STDERR) 	. Index spec: { expireAfterSeconds: null, name: "_updatedAt_1", key: { _updatedAt: 1 } } :: caused by :: TTL index 'expireAfterSeconds' option must be numeric, but received a type of 'null

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 10, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2025

⚠️ No Changeset found

Latest commit: a4fc56c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sampaiodiego sampaiodiego changed the title regression: fix apps logs expire as undefined` regression: fix apps logs expire as undefined Apr 10, 2025
@sampaiodiego sampaiodiego marked this pull request as ready for review April 10, 2025 20:32
@sampaiodiego sampaiodiego requested a review from a team as a code owner April 10, 2025 20:32
@github-actions
Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35774/

Built to branch gh-pages at 2025-04-10 20:41 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.60%. Comparing base (3f7e7f8) to head (a4fc56c).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35774      +/-   ##
===========================================
- Coverage    59.64%   59.60%   -0.04%     
===========================================
  Files         2832     2832              
  Lines        68313    68350      +37     
  Branches     15129    15145      +16     
===========================================
- Hits         40747    40742       -5     
- Misses       24960    25000      +40     
- Partials      2606     2608       +2     
Flag Coverage Δ
unit 75.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sampaiodiego sampaiodiego added this to the 7.6.0 milestone Apr 10, 2025
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Apr 10, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 10, 2025
@sampaiodiego sampaiodiego merged commit 49843c8 into develop Apr 10, 2025
53 of 55 checks passed
@sampaiodiego sampaiodiego deleted the regression-apps-logs-index branch April 10, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants