Skip to content

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 14, 2025

Refactor AppsLogsModel to remove _updatedAtIndexOptions and use modelIndexes

This change removes the _updatedAtIndexOptions parameter and instead uses the modelIndexes method to determine the updated index options.

Without overwriting modelIndexes to return a value, _updatedAtIndexOptions is never added.

The current implementation check on Apps.isInitialized() which is false during the first attempt, but you can seethe problem when the TTL setting is changed.

@ggazzo ggazzo requested a review from a team as a code owner March 14, 2025 03:50
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 14, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2025

🦋 Changeset detected

Latest commit: 4f4c8f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/model-typings Patch
@rocket.chat/models Patch
@rocket.chat/apps Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
rocketchat-services Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/presence Patch
@rocket.chat/network-broker Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ggazzo ggazzo added this to the 7.5.0 milestone Mar 14, 2025
@ggazzo ggazzo marked this pull request as draft March 14, 2025 03:54
@ggazzo ggazzo force-pushed the fix/apps-engine-ttl branch from 0b31339 to d865af9 Compare March 14, 2025 04:31
@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35497/

Built to branch gh-pages at 2025-03-21 14:27 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.73%. Comparing base (af03a61) to head (4f4c8f7).
Report is 9 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35497      +/-   ##
===========================================
+ Coverage    59.66%   59.73%   +0.06%     
===========================================
  Files         2826     2830       +4     
  Lines        68282    68403     +121     
  Branches     15128    15171      +43     
===========================================
+ Hits         40741    40861     +120     
+ Misses       24930    24929       -1     
- Partials      2611     2613       +2     
Flag Coverage Δ
unit 75.92% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo force-pushed the fix/apps-engine-ttl branch from b31688c to e82b5e3 Compare March 20, 2025 19:28
@ggazzo ggazzo changed the title fix: AppsLogsModel TTL chore: Remove Apps log TTL configurable Mar 20, 2025
@ggazzo ggazzo force-pushed the fix/apps-engine-ttl branch from e82b5e3 to 3adfef2 Compare March 20, 2025 19:33
@ggazzo ggazzo marked this pull request as ready for review March 20, 2025 19:33
@ggazzo ggazzo changed the title chore: Remove Apps log TTL configurable fix: Add Apps log TTL index Mar 20, 2025
d-gubert
d-gubert previously approved these changes Mar 21, 2025
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Mar 21, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 21, 2025
@ggazzo ggazzo merged commit 45a93a7 into develop Mar 21, 2025
8 of 9 checks passed
@ggazzo ggazzo deleted the fix/apps-engine-ttl branch March 21, 2025 14:22
abhinavkrin pushed a commit that referenced this pull request Mar 24, 2025
abhinavkrin pushed a commit that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants