-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: Add Apps log TTL index #35497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add Apps log TTL index #35497
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 4f4c8f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0b31339 to
d865af9
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35497 +/- ##
===========================================
+ Coverage 59.66% 59.73% +0.06%
===========================================
Files 2826 2830 +4
Lines 68282 68403 +121
Branches 15128 15171 +43
===========================================
+ Hits 40741 40861 +120
+ Misses 24930 24929 -1
- Partials 2611 2613 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
b31688c to
e82b5e3
Compare
e82b5e3 to
3adfef2
Compare
Co-authored-by: Diego Sampaio <[email protected]>
Co-authored-by: Diego Sampaio <[email protected]>
Co-authored-by: Diego Sampaio <[email protected]>
Refactor AppsLogsModel to remove
_updatedAtIndexOptionsand usemodelIndexesThis change removes the
_updatedAtIndexOptionsparameter and instead uses themodelIndexesmethod to determine the updated index options.Without overwriting
modelIndexesto return a value,_updatedAtIndexOptionsis never added.The current implementation check on
Apps.isInitialized()which isfalseduring the first attempt, but you can seethe problem when the TTL setting is changed.