-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: Video conference call again not working properly #35545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: fc1115f The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35545 +/- ##
===========================================
- Coverage 59.66% 59.66% -0.01%
===========================================
Files 2826 2826
Lines 68379 68378 -1
Branches 15149 15149
===========================================
- Hits 40801 40800 -1
Misses 24964 24964
Partials 2614 2614
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
yash-rajpal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed changes (including videos or screenshots)
Introduced here: #35047
Due the refactor we introduced in
7.4,useVideoConfLoadCapabilitiesare losing theVideoConfManagerreference so when the user tries to call again it failsIssue(s)
Steps to test or reproduce
Further comments
SUP-752