-
Notifications
You must be signed in to change notification settings - Fork 13k
refactor: Reduce VideoConfContext exhausting types
#35047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
VideoConfContext exhausting types
d21c733 to
a1bdf77
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35047 +/- ##
===========================================
- Coverage 59.22% 59.21% -0.01%
===========================================
Files 2824 2824
Lines 68069 67989 -80
Branches 15151 15130 -21
===========================================
- Hits 40314 40260 -54
+ Misses 24924 24903 -21
+ Partials 2831 2826 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
This PR aims to reduce the exhausting types from
VideoConfContextand memoizes SyncExternalStore queries. It also helps to create and use mocks inmock-providerspackage, allowing to introduce unit testsIssue(s)
Steps to test or reproduce
Further comments