Skip to content

Conversation

@Anxhul10
Copy link
Contributor

Proposed changes (including videos or screenshots)

Removed key icon from the password input box which does nothing replaced with eye icon when clicked it shows the password.
Screencast from 2025-02-12 00-22-35.webm

Issue(s)

closes #35166

Steps to test or reproduce

  1. select profile
  2. choose security
  3. fill up the password
  4. click on the eye icon

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 27, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: 7d40ff1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you just remove the addon in PasswordInput inside ChangePassword component will do what you're looking for

@dougfabris dougfabris self-assigned this Feb 28, 2025
@Anxhul10 Anxhul10 requested a review from a team as a code owner February 28, 2025 16:18
@Anxhul10 Anxhul10 requested a review from dougfabris February 28, 2025 16:25
@dougfabris dougfabris changed the title feat: added eye icon to toggle password visibility on click fix: Displays password content toggle in account security page Feb 28, 2025
@dougfabris dougfabris added this to the 7.5.0 milestone Feb 28, 2025
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Mar 6, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 6, 2025
@kodiakhq kodiakhq bot merged commit 142a9b9 into RocketChat:develop Mar 6, 2025
43 of 44 checks passed
@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.46%. Comparing base (279dc55) to head (7d40ff1).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35357   +/-   ##
========================================
  Coverage    59.46%   59.46%           
========================================
  Files         2830     2830           
  Lines        68582    68582           
  Branches     15178    15178           
========================================
  Hits         40781    40781           
  Misses       25132    25132           
  Partials      2669     2669           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Key" Option in Password Field Does Nothing

2 participants