-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: Displays password content toggle in account security page #35357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Displays password content toggle in account security page #35357
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 7d40ff1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dougfabris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you just remove the addon in PasswordInput inside ChangePassword component will do what you're looking for
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35357 +/- ##
========================================
Coverage 59.46% 59.46%
========================================
Files 2830 2830
Lines 68582 68582
Branches 15178 15178
========================================
Hits 40781 40781
Misses 25132 25132
Partials 2669 2669 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Removed key icon from the password input box which does nothing replaced with eye icon when clicked it shows the password.
Screencast from 2025-02-12 00-22-35.webm
Issue(s)
closes #35166
Steps to test or reproduce