Skip to content

fix: Displays password content toggle in account security page #35357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 6 commits into from
Mar 6, 2025
Merged

fix: Displays password content toggle in account security page #35357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7674a55
feat: added eye icon to toggle password visibility on click
Anxhul10 Feb 27, 2025
19678ad
feat:password-icon-click
Anxhul10 Feb 28, 2025
eaec2ca
fixed lint errors
Anxhul10 Feb 28, 2025
6f988c4
Merge branch 'develop' into feat/password-icon-click
Anxhul10 Feb 28, 2025
45395e1
chore: update changeset
dougfabris Mar 6, 2025
7d40ff1
Merge branch 'develop' into feat/password-icon-click
kodiakhq[bot] Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lemon-mirrors-battle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': patch
---

Fixes an issue where password inputs inside account security page is displaying a key icon instead of eye icon content toggler
4 changes: 1 addition & 3 deletions apps/meteor/client/views/account/security/ChangePassword.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Box, Field, FieldError, FieldGroup, FieldHint, FieldLabel, FieldRow, Icon, PasswordInput } from '@rocket.chat/fuselage';
import { Box, Field, FieldError, FieldGroup, FieldHint, FieldLabel, FieldRow, PasswordInput } from '@rocket.chat/fuselage';
import { PasswordVerifier, useValidatePassword } from '@rocket.chat/ui-client';
import { useMethod, useToastMessageDispatch } from '@rocket.chat/ui-contexts';
import { useId } from 'react';
Expand Down Expand Up @@ -62,7 +62,6 @@ const ChangePassword = (props: AllHTMLAttributes<HTMLFormElement>) => {
id={passwordId}
error={errors.password?.message}
flexGrow={1}
addon={<Icon name='key' size='x20' />}
disabled={!allowPasswordChange}
aria-describedby={`${passwordVerifierId} ${passwordId}-hint ${passwordId}-error`}
aria-invalid={errors.password ? 'true' : 'false'}
Expand Down Expand Up @@ -94,7 +93,6 @@ const ChangePassword = (props: AllHTMLAttributes<HTMLFormElement>) => {
id={confirmPasswordId}
error={errors.confirmationPassword?.message}
flexGrow={1}
addon={<Icon name='key' size='x20' />}
disabled={!allowPasswordChange || !passwordIsValid}
aria-required={password !== '' ? 'true' : 'false'}
aria-invalid={errors.confirmationPassword ? 'true' : 'false'}
Expand Down
Loading