-
Notifications
You must be signed in to change notification settings - Fork 13k
regression: show message asking for updating workspace when unsupported version #35350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: show message asking for updating workspace when unsupported version #35350
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.4.0 #35350 +/- ##
==============================================
Coverage 59.46% 59.46%
==============================================
Files 2830 2830
Lines 68627 68627
Branches 15181 15181
==============================================
Hits 40808 40808
Misses 25149 25149
Partials 2670 2670
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@kody start-review |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Proposed changes (including videos or screenshots)
Since the changes introduced in: #35059 we changed how the errors are returned to the client, abstracting away marketplace errors with our own errors. But, since we used to match on the string value of the error (returned by marketplace) we broken this screen.
The fix is really simple since it is a regression and I don't think we should do major refactorings, but as the backend goes through a more standardized version of throwing marketplace errors, we should look into handling it in the marketplace more gracefully.
Issue(s)
Steps to test or reproduce
Further comments
CONN-550
This pull request addresses a regression issue in the Rocket.Chat repository by updating the error message handling for unsupported marketplace versions. Specifically, it modifies the
AppsPageContent.tsxfile to improve the check for unsupported versions and includes a TODO comment suggesting the future implementation of error codes instead of relying on string matching. The changes are intended for therelease-7.4.0branch, originating from theregression/not-showing-unsupported-versionbranch.