Skip to content

Conversation

@Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Feb 27, 2025

Proposed changes (including videos or screenshots)

Since the changes introduced in: #35059 we changed how the errors are returned to the client, abstracting away marketplace errors with our own errors. But, since we used to match on the string value of the error (returned by marketplace) we broken this screen.
The fix is really simple since it is a regression and I don't think we should do major refactorings, but as the backend goes through a more standardized version of throwing marketplace errors, we should look into handling it in the marketplace more gracefully.

Captura de Tela 2025-02-27 às 10 20 36

Issue(s)

Steps to test or reproduce

Further comments

CONN-550


This pull request addresses a regression issue in the Rocket.Chat repository by updating the error message handling for unsupported marketplace versions. Specifically, it modifies the AppsPageContent.tsx file to improve the check for unsupported versions and includes a TODO comment suggesting the future implementation of error codes instead of relying on string matching. The changes are intended for the release-7.4.0 branch, originating from the regression/not-showing-unsupported-version branch.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 27, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: 6c6a16a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Gustrb Gustrb marked this pull request as ready for review February 27, 2025 13:21
@Gustrb Gustrb requested a review from a team as a code owner February 27, 2025 13:21
@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.46%. Comparing base (2c79559) to head (6c6a16a).
Report is 3 commits behind head on release-7.4.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.4.0   #35350   +/-   ##
==============================================
  Coverage          59.46%   59.46%           
==============================================
  Files               2830     2830           
  Lines              68627    68627           
  Branches           15181    15181           
==============================================
  Hits               40808    40808           
  Misses             25149    25149           
  Partials            2670     2670           
Flag Coverage Δ
unit 75.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rique223
Copy link
Contributor

@kody start-review

@kody-ai
Copy link

kody-ai bot commented Feb 27, 2025

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization

Access your configuration settings here.

@aleksandernsilva aleksandernsilva added this to the 7.4.0 milestone Feb 27, 2025
@Gustrb Gustrb added the stat: QA assured Means it has been tested and approved by a company insider label Feb 27, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 27, 2025
@kodiakhq kodiakhq bot merged commit 6a10ab7 into release-7.4.0 Feb 27, 2025
57 of 58 checks passed
@kodiakhq kodiakhq bot deleted the regression/not-showing-unsupported-version branch February 27, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants