Skip to content

Conversation

@Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Jan 29, 2025

Proposed changes (including videos or screenshots)

This stems from the fact the we currently simply call marketplace-api from our core application without ever validating the return type of the API is actually what we expected. Since marketplace-api is written in a different programming language, and it is not open source, people tend to have less visibility when something changes, so we must be able to catch that as soon as possible, and never introduce a broken return inside our database (really hard to fix, since it would require migrating the data, either continuously or preemptively).

Issue(s)

Steps to test or reproduce

Further comments

CONN-64
CONN-491
CONN-492

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 29, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2025

⚠️ No Changeset found

Latest commit: 43fc9c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.20%. Comparing base (cd8d4b9) to head (43fc9c2).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35059      +/-   ##
===========================================
- Coverage    59.20%   59.20%   -0.01%     
===========================================
  Files         2823     2823              
  Lines        67972    67911      -61     
  Branches     15120    15099      -21     
===========================================
- Hits         40245    40204      -41     
+ Misses       24900    24885      -15     
+ Partials      2827     2822       -5     
Flag Coverage Δ
unit 75.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35059/

Built to branch gh-pages at 2025-02-04 18:23 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@Gustrb Gustrb marked this pull request as ready for review January 29, 2025 19:09
@Gustrb Gustrb added this to the 7.4.0 milestone Jan 30, 2025
@Gustrb Gustrb requested a review from KevLehman January 30, 2025 14:18
@Gustrb Gustrb added the stat: QA assured Means it has been tested and approved by a company insider label Feb 6, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 6, 2025
@Gustrb Gustrb added stat: QA assured Means it has been tested and approved by a company insider and removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Feb 10, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 10, 2025
@kodiakhq kodiakhq bot merged commit 0a99a40 into develop Feb 10, 2025
47 of 48 checks passed
@kodiakhq kodiakhq bot deleted the chore/add-wrapper-for-fetching-marketplace-apps branch February 10, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants