-
Notifications
You must be signed in to change notification settings - Fork 13.1k
chore: add validation layer to marketplace comms #35059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add validation layer to marketplace comms #35059
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35059 +/- ##
===========================================
- Coverage 59.20% 59.20% -0.01%
===========================================
Files 2823 2823
Lines 67972 67911 -61
Branches 15120 15099 -21
===========================================
- Hits 40245 40204 -41
+ Misses 24900 24885 -15
+ Partials 2827 2822 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Proposed changes (including videos or screenshots)
This stems from the fact the we currently simply call marketplace-api from our core application without ever validating the return type of the API is actually what we expected. Since marketplace-api is written in a different programming language, and it is not open source, people tend to have less visibility when something changes, so we must be able to catch that as soon as possible, and never introduce a broken return inside our database (really hard to fix, since it would require migrating the data, either continuously or preemptively).
Issue(s)
Steps to test or reproduce
Further comments
CONN-64
CONN-491
CONN-492