-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: IPreRoomCreateModify not persisting changes made by apps #35342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: d77316a The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35342 +/- ##
========================================
Coverage 59.42% 59.42%
========================================
Files 2829 2829
Lines 68332 68332
Branches 15133 15133
========================================
Hits 40608 40608
Misses 25066 25066
Partials 2658 2658
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
The listener handler for the
IPreRoomCreateModifywas not returning the changes applied by apps during execution.https://rocketchat.atlassian.net/browse/CONN-572
Issue(s)
Steps to test or reproduce
Further comments