Skip to content

fix: IPreRoomCreateModify not persisting changes made by apps #35342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sampaiodiego merged 3 commits into from
Mar 20, 2025
Merged

fix: IPreRoomCreateModify not persisting changes made by apps #35342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a6f46c
Fix wrong return value on IPreRoomCreateModify event
d-gubert Feb 26, 2025
93a61db
Add changeset
d-gubert Feb 26, 2025
d77316a
Merge branch 'develop' into fix/apps-pre-create-room-event
kodiakhq[bot] Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/pretty-dragons-remain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@rocket.chat/apps-engine': patch
'@rocket.chat/meteor': patch
---

Fixes an issue that prevents modifications from being persisted in the IPreRoomCreateModify
3 changes: 2 additions & 1 deletion packages/apps-engine/src/server/managers/AppListenerManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ export class AppListenerManager {
return !!(lockedEventList && lockedEventList.size);
}

/* eslint-disable-next-line complexity */
public async executeListener<I extends keyof IListenerExecutor>(int: I, data: IListenerExecutor[I]['args'][0]): Promise<IListenerExecutor[I]['result']> {
if (this.isEventBlocked(int)) {
throw new EssentialAppDisabledException('There is one or more apps that are essential to this event but are disabled');
Expand Down Expand Up @@ -794,7 +795,7 @@ export class AppListenerManager {
}
}

return data;
return room;
}

private async executePostRoomCreate(data: IRoom): Promise<void> {
Expand Down
Loading