Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Fix file upload modal not receiving focus on description field #34001

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

tiagoevanp
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Introduced by #33218

Copy link
Contributor

dionisio-bot bot commented Nov 19, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 3e22fab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tiagoevanp tiagoevanp added this to the 7.1.0 milestone Nov 19, 2024
@tiagoevanp tiagoevanp added the stat: QA assured Means it has been tested and approved by a company insider label Nov 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 19, 2024
@tiagoevanp tiagoevanp marked this pull request as ready for review November 19, 2024 19:35
@tiagoevanp tiagoevanp requested a review from a team as a code owner November 19, 2024 19:35
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34001/
on branch gh-pages at 2024-11-19 19:40 UTC

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.73%. Comparing base (14d3425) to head (3e22fab).
Report is 10 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34001      +/-   ##
===========================================
+ Coverage    75.18%   75.73%   +0.54%     
===========================================
  Files          495      507      +12     
  Lines        21600    21799     +199     
  Branches      5362     5343      -19     
===========================================
+ Hits         16241    16509     +268     
+ Misses        4717     4648      -69     
  Partials       642      642              
Flag Coverage Δ
unit 75.73% <ø> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@ggazzo ggazzo merged commit ef0c5eb into develop Nov 19, 2024
40 checks passed
@ggazzo ggazzo deleted the regression/file-upload-description-focus branch November 19, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants