fix: File Upload description bypassing message maximum character limit setting #33218
+154
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 2babbb1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33218 +/- ##
============================================
- Coverage 75.18% 58.90% -16.29%
============================================
Files 495 2794 +2299
Lines 21600 66737 +45137
Branches 5362 15003 +9641
============================================
+ Hits 16241 39314 +23073
- Misses 4717 24608 +19891
- Partials 642 2815 +2173
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
abhinavkrin
previously requested changes
Sep 23, 2024
There was a problem hiding this comment.
Hello @MartinSchoeler,
Would it be a good idea to implement the check on the backend as well? Currently, users can send long messages through the API bypassing the character limit.
MartinSchoeler
force-pushed
the
file-description-char-limit
branch
from
033721e to
e44659c
Compare
MartinSchoeler
force-pushed
the
file-description-char-limit
branch
from
e44659c to
2d32fd6
Compare
MartinSchoeler
force-pushed
the
file-description-char-limit
branch
2 times, most recently
from
e8a5274 to
44f84b8
Compare
MartinSchoeler
force-pushed
the
file-description-char-limit
branch
from
44f84b8 to
3558dc9
Compare
MartinSchoeler
dismissed
abhinavkrin’s stale review
Could you review again? Added the changes that were requested, thanks!
abhinavkrin
previously approved these changes
Oct 22, 2024
tiagoevanp
previously approved these changes
Oct 22, 2024
gabriellsh
requested changes
Oct 22, 2024
gabriellsh
changed the title
MartinSchoeler
dismissed stale reviews from tiagoevanp and abhinavkrin
via
a7da7b5
gabriellsh
previously approved these changes
Oct 24, 2024
MarcosSpessatto
requested changes
Oct 28, 2024
MarcosSpessatto
approved these changes
Nov 11, 2024
scuciatto
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Added the message character limit restriction to the file upload description field, before this, you could send a message bigger than the limit by sending a file with a large description
Issue(s)
SUP-620