Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump rocketchat-icons #33119

Merged
merged 4 commits into from
Aug 21, 2024
Merged

chore: bump rocketchat-icons #33119

merged 4 commits into from
Aug 21, 2024

Conversation

Dnouv
Copy link
Member

@Dnouv Dnouv commented Aug 21, 2024

Proposed changes (including videos or screenshots)

  • Bump "@rocket.chat/icons": "^0.36.0" -> "@rocket.chat/icons": "~0.38.0"

Issue(s)

Steps to test or reproduce

Further comments

No changeset since a chore

Copy link
Contributor

dionisio-bot bot commented Aug 21, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: 5111d91

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.43%. Comparing base (dd37ea1) to head (5111d91).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33119   +/-   ##
========================================
  Coverage    59.43%   59.43%           
========================================
  Files         2547     2547           
  Lines        63265    63265           
  Branches     14237    14237           
========================================
  Hits         37604    37604           
  Misses       22941    22941           
  Partials      2720     2720           
Flag Coverage Δ
unit 76.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Dnouv Dnouv marked this pull request as ready for review August 21, 2024 08:39
@Dnouv Dnouv requested a review from a team as a code owner August 21, 2024 08:39
tassoevan
tassoevan previously approved these changes Aug 21, 2024
@tassoevan tassoevan added this to the 6.12 milestone Aug 21, 2024
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Aug 21, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 21, 2024
@kodiakhq kodiakhq bot merged commit eb5e60e into develop Aug 21, 2024
46 checks passed
@kodiakhq kodiakhq bot deleted the chore/bump_rc_icons branch August 21, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants