-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce new categories field for UI Action Buttons #33066
Conversation
🦋 Changeset detectedLatest commit: d587947 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33066 +/- ##
========================================
Coverage 58.59% 58.59%
========================================
Files 2739 2739
Lines 65702 65705 +3
Branches 14830 14827 -3
========================================
+ Hits 38497 38500 +3
Misses 24425 24425
Partials 2780 2780
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't necessary, but you might consider subdividing the useMessageToolbarStarsAppsAction
logic into two functions like this:
const filterActions = useCallback((actions) => { ...filtering logic... }, [{dependencies}]);
const mapActions = useCallback((actions) => { ...mapping logic... }, [{dependencies}]);
Then, you can use them like this:
const data = useMemo( () => mapActions(filterActions(queryResult.data)), [{dependencies}] );
This approach better adheres to functional programming best practices, improves readability, and makes future code extensions/refactors easier. However, if this suggestion isn't in the scope of the PR, feel free to disregard it.
apps/meteor/client/components/message/toolbar/MessageToolbarStarsActionMenu.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/components/message/toolbar/MessageToolbarStarsActionMenu.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Tasso Evangelista <[email protected]>
Proposed changes (including videos or screenshots)
category: AI
on the App buttons, those buttons will be rendered on this new context.Issue(s)
Steps to test or reproduce
Further comments