-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Omnichannel): Use Correct components on ChatInfo #32592
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 3dc0548 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32592 +/- ##
===========================================
+ Coverage 56.65% 56.78% +0.13%
===========================================
Files 2504 2504
Lines 55524 55514 -10
Branches 11442 11439 -3
===========================================
+ Hits 31456 31526 +70
+ Misses 21380 21277 -103
- Partials 2688 2711 +23
Flags with carried forward coverage won't be shown. Click here to find out more. |
eb6c0c5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid using InfoPanel.Component
notation. Instead prefer using InfoPanelComponent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…/removeUsers * 'develop' of github.com:RocketChat/Rocket.Chat: refactor(omnichannel): replace create and find by findAndUpdate (#32773) chore: Bump apps engine 1.44-alpha (#32774) refactor(client): Remove usage of `React.FC` type (#32760) refactor(Livechat): `Livechat/Message/markdown.js` -> TS (#32295) refactor(omnichannel): spare few Room.find on requestRoom method (#32363) refactor: `dispatchInquiryPosition` being called multiple times (#32767) fix: SAML "Overwrite user fullname" setting is not being honored (#32628) fix(Omnichannel): Use Correct components on ChatInfo (#32592)
CORE-477
Fixes Missing line breaks on Omnichannel Room Info Panel by using the correct component for data view