Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor chatInfo/Directory #32571

Closed
wants to merge 4 commits into from
Closed

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Jun 7, 2024

Refactors chatInfo and chatInfoDirectory to ts and makes them use the appropriate components for dataview

REQUIRES #32592

Copy link
Contributor

dionisio-bot bot commented Jun 7, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 7, 2024

⚠️ No Changeset found

Latest commit: a1d1077

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.74%. Comparing base (d7de0a9) to head (a1d1077).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32571      +/-   ##
===========================================
+ Coverage    56.68%   56.74%   +0.06%     
===========================================
  Files         2504     2502       -2     
  Lines        55524    55528       +4     
  Branches     11442    11484      +42     
===========================================
+ Hits         31472    31509      +37     
+ Misses       21368    21306      -62     
- Partials      2684     2713      +29     
Flag Coverage Δ
e2e 56.44% <55.55%> (-0.04%) ⬇️
unit 72.21% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review June 10, 2024 11:45
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner June 10, 2024 11:45
dougfabris
dougfabris previously approved these changes Jun 10, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dougfabris dougfabris added this to the 6.10 milestone Jun 10, 2024
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use this PR to fix the issue only? I believe it would be better to keep the conversion to TS in another PR.

@dougfabris dougfabris dismissed their stale review June 11, 2024 14:54

canceling, due to tech lead request

@MartinSchoeler MartinSchoeler changed the base branch from develop to CORE-477 June 12, 2024 13:32
@scuciatto scuciatto removed this from the 6.10 milestone Jun 20, 2024
Base automatically changed from CORE-477 to develop July 11, 2024 16:58
@dougfabris
Copy link
Member

Closing this one, since it's going to be handled in the Single Contact Identification project

@dougfabris dougfabris closed this Jul 11, 2024
@dougfabris dougfabris deleted the refactor-chatInfo branch July 12, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants