-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor chatInfo/Directory #32571
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32571 +/- ##
===========================================
+ Coverage 56.68% 56.74% +0.06%
===========================================
Files 2504 2502 -2
Lines 55524 55528 +4
Branches 11442 11484 +42
===========================================
+ Hits 31472 31509 +37
+ Misses 21368 21306 -62
- Partials 2684 2713 +29
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use this PR to fix the issue only? I believe it would be better to keep the conversion to TS in another PR.
Closing this one, since it's going to be handled in the Single Contact Identification project |
Refactors chatInfo and chatInfoDirectory to ts and makes them use the appropriate components for dataview
REQUIRES #32592