chore: Remove references to EE code from the app events - #31926
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #31926 +/- ##
===========================================
- Coverage 54.53% 54.46% -0.08%
===========================================
Files 2293 2286 -7
Lines 50523 50462 -61
Branches 10317 10315 -2
===========================================
- Hits 27552 27483 -69
- Misses 20472 20485 +13
+ Partials 2499 2494 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
left a comment
There was a problem hiding this comment.
how can we make sure there is no code running during the startup before registerOrchestrator is actually called? I wonder if having Apps?.something all over the place can introduce silence bugs where we think it should be defined already but it is not.. what is your take on this?
I guess I can replace it with a proxy that do something if the orchestrator is not registered, but in theory there won't be any app event triggered before the server is fully loaded. |
* develop: (71 commits) fix: search room not reactive after room name changes (#32123) test: fix `should edit name of targetChannel` flaky test (#32121) fix: UI allowing to mark room as favorite despite room was not a `default` room (#32063) chore: Remove duplicated `ChannelDeletionTable` (#32114) test(livechat): fix Department flaky test (#32102) test(livechat): File upload settings (#32060) test: contact center after hook calling wrong endpoint (#32094) fix(livechat): registering guest multiple times cause message loss (#32069) test: allow csp for livechat tests (#32116) chore: Move portals to the portals folder (#32090) test: `InitialData.insertAdminUserFromEnv` (#32066) fix: `CSP` error right after `setInlineScriptsAllowed` (#32108) chore: Create/Edit room consistency (#31960) chore: Remove references to EE code from the app events (#31926) test(Livechat): Clean up after registerGuest() test (#32092) test: make presence api tests fully independent (#31782) test: make roles fully independent (#31783) chore: bump version to 7.0.0-develop test: make login api tests fully independent (#31786) fix!: api login should not suggest which credential is wrong (#32086) ...
Proposed changes (including videos or screenshots)
Issue(s)
FOSS-5
Steps to test or reproduce
Further comments