Skip to content

chore: Remove references to EE code from the app events - #31926

Merged
ggazzo merged 14 commits into
developfrom
foss/app-events-2
Apr 1, 2024
Merged

chore: Remove references to EE code from the app events#31926
ggazzo merged 14 commits into
developfrom
foss/app-events-2

Conversation

@pierre-lehnen-rc

@pierre-lehnen-rc pierre-lehnen-rc commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

FOSS-5

Steps to test or reproduce

Further comments

@changeset-bot

changeset-bot Bot commented Mar 7, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c23da0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pierre-lehnen-rc
pierre-lehnen-rc marked this pull request as ready for review March 7, 2024 14:22
@pierre-lehnen-rc
pierre-lehnen-rc requested review from a team as code owners March 7, 2024 14:22
@codecov

codecov Bot commented Mar 7, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 14.28571% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 54.46%. Comparing base (e350be5) to head (c23da0e).
Report is 78 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31926      +/-   ##
===========================================
- Coverage    54.53%   54.46%   -0.08%     
===========================================
  Files         2293     2286       -7     
  Lines        50523    50462      -61     
  Branches     10317    10315       -2     
===========================================
- Hits         27552    27483      -69     
- Misses       20472    20485      +13     
+ Partials      2499     2494       -5     
Flag Coverage Δ
e2e 53.46% <ø> (-0.09%) ⬇️
e2e-api 40.06% <14.28%> (-0.09%) ⬇️
unit 75.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can we make sure there is no code running during the startup before registerOrchestrator is actually called? I wonder if having Apps?.something all over the place can introduce silence bugs where we think it should be defined already but it is not.. what is your take on this?

@pierre-lehnen-rc

Copy link
Copy Markdown
Contributor Author

how can we make sure there is no code running during the startup before registerOrchestrator is actually called? I wonder if having Apps?.something all over the place can introduce silence bugs where we think it should be defined already but it is not.. what is your take on this?

I guess I can replace it with a proxy that do something if the orchestrator is not registered, but in theory there won't be any app event triggered before the server is fully loaded.

@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 28, 2024
@ggazzo
ggazzo merged commit 9b53024 into develop Apr 1, 2024
@ggazzo
ggazzo deleted the foss/app-events-2 branch April 1, 2024 15:43
gabriellsh added a commit that referenced this pull request Apr 4, 2024
* develop: (71 commits)
  fix: search room not reactive after room name changes (#32123)
  test: fix `should edit name of targetChannel` flaky test (#32121)
  fix: UI allowing to mark room as favorite despite room was not a `default` room (#32063)
  chore: Remove duplicated `ChannelDeletionTable` (#32114)
  test(livechat): fix Department flaky test (#32102)
  test(livechat): File upload settings (#32060)
  test: contact center after hook calling wrong endpoint (#32094)
  fix(livechat): registering guest multiple times cause message loss (#32069)
  test: allow csp for livechat tests (#32116)
  chore: Move portals to the portals folder (#32090)
  test: `InitialData.insertAdminUserFromEnv` (#32066)
  fix: `CSP` error right after `setInlineScriptsAllowed` (#32108)
  chore: Create/Edit room consistency (#31960)
  chore: Remove references to EE code from the app events (#31926)
  test(Livechat): Clean up after registerGuest() test (#32092)
  test: make presence api tests fully independent (#31782)
  test: make roles fully independent (#31783)
  chore: bump version to 7.0.0-develop
  test: make login api tests fully independent (#31786)
  fix!: api login should not suggest which credential is wrong (#32086)
  ...
@scuciatto scuciatto added this to the 6.8 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants