fix: setDepartment not persisting on chat closed - #31792
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 9855bc6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31792 +/- ##
===========================================
+ Coverage 54.55% 54.57% +0.02%
===========================================
Files 2287 2293 +6
Lines 50365 50440 +75
Branches 10276 10292 +16
===========================================
+ Hits 27476 27529 +53
- Misses 20401 20412 +11
- Partials 2488 2499 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
previously approved these changes
Feb 26, 2024
dionisio-bot
Bot
added
the
stat: ready to merge
AllanPazRibeiro
previously approved these changes
Mar 4, 2024
MarcosSpessatto
previously approved these changes
Mar 4, 2024
ggazzo
requested changes
Mar 8, 2024
ggazzo
left a comment
ggazzo
left a comment
Member
There was a problem hiding this comment.
please provide some test to make sure we never face this again
MartinSchoeler
dismissed stale reviews from MarcosSpessatto and AllanPazRibeiro
via
March 8, 2024 19:21
3804b43
dionisio-bot
Bot
added
stat: ready to merge
MartinSchoeler
marked this pull request as draft
March 8, 2024 19:40
dionisio-bot
Bot
added
stat: ready to merge
MartinSchoeler
marked this pull request as ready for review
March 8, 2024 21:38
dionisio-bot
Bot
added
stat: ready to merge
ggazzo
approved these changes
Mar 11, 2024
dionisio-bot
Bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Mar 12, 2024
…modalRegions * 'develop' of github.com:RocketChat/Rocket.Chat: (77 commits) fix: CRM integration mismatch on callback type (#31880) test: make outgoing integrations fully independent (#31656) fix: setDepartment not persisting on chat closed (#31792) fix: Trigger app event after inquiry is created (#31909) regression: Favorite action announcement (#31940) regression: Prevents `ImageGallery` to restore focus on message (#31869) i18n: Add missing swedish translation for "Create direct message" key (#31945) feat(message-parser): add timestamps pattern (#31810) fix: convert network broker stopped lifecycle method to async (#31927) regression: undefined guest causing issues (#31932) refactor: use uiContexts on livechat (#31919) fix: Validate rooms are not taken before processing by queue (#31896) fix: livechat sdk reconnect not resubscribing (#31941) fix: Quote attachments are not deleted on message update (#31660) Revert "regression: Favorite action announcement" (#31935) chore: improve room `LeaderBar` behavior with date bubble (#31933) regression: Favorite action announcement (#31934) chore: Migrate notifyUsersOnMessage to TypeScript (#31877) fix: Mentions stop working when mentioned user changes username (#31860) regression: `RoomBody` unread and new messages behavior (#31929) ...
ggazzo
pushed a commit
that referenced
this pull request
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUP-484
Fixes issue of the
setDepartmentLivechat API method not setting the store value properly (is was only setting on the guest object)