-
Notifications
You must be signed in to change notification settings - Fork 13k
chore: don't ignoreUndefined
#31497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: don't ignoreUndefined
#31497
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #31497 +/- ##
===========================================
- Coverage 59.62% 59.62% -0.01%
===========================================
Files 2829 2830 +1
Lines 68291 68304 +13
Branches 15135 15135
===========================================
+ Hits 40719 40724 +5
- Misses 24963 24971 +8
Partials 2609 2609
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
🎂 |
|
/bark |
|
AU AU |
|
/bark |
|
AU AU |
|
/bark |
|
woof |
|
KevLehman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave the symbolic approve for when this PR is finally opened.
72a1c10 to
0071ed1
Compare
pierre-lehnen-rc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging I suggest we double check every query that uses the $exists operator to ensure that it's not checking for something that will start existing as undefined.
f431509 to
43af42c
Compare
43af42c to
ff4db20
Compare
ff4db20 to
da28e8f
Compare
Proposed changes (including videos or screenshots)
This was set to
trueby default from Meteor due to an inconsistency withminimongobut it actually caused a lot of issues for us in the past.. since we don't care too much about this inconsistencies I'm proposing we change the default value. Ref.: meteor/meteor#6051 meteor/meteor#9444 https://www.mongodb.com/docs/drivers/node/current/fundamentals/bson/undefined-values/Issue(s)
ARCH-1447
Steps to test or reproduce
Further comments