Skip to content

Conversation

@sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Jan 19, 2024

Proposed changes (including videos or screenshots)

This was set to true by default from Meteor due to an inconsistency with minimongo but it actually caused a lot of issues for us in the past.. since we don't care too much about this inconsistencies I'm proposing we change the default value. Ref.: meteor/meteor#6051 meteor/meteor#9444 https://www.mongodb.com/docs/drivers/node/current/fundamentals/bson/undefined-values/

Issue(s)

ARCH-1447

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2024

⚠️ No Changeset found

Latest commit: da28e8f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: Patch coverage is 48.07692% with 27 lines in your changes missing coverage. Please review.

Project coverage is 59.62%. Comparing base (2c72ac4) to head (da28e8f).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31497      +/-   ##
===========================================
- Coverage    59.62%   59.62%   -0.01%     
===========================================
  Files         2829     2830       +1     
  Lines        68291    68304      +13     
  Branches     15135    15135              
===========================================
+ Hits         40719    40724       +5     
- Misses       24963    24971       +8     
  Partials      2609     2609              
Flag Coverage Δ
unit 75.59% <48.07%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 12, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@sampaiodiego
Copy link
Member Author

🎂

@sampaiodiego
Copy link
Member Author

/bark

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 17, 2025

AU AU

@sampaiodiego
Copy link
Member Author

/bark

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 17, 2025

AU AU

@sampaiodiego
Copy link
Member Author

/bark

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 17, 2025

woof

@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-31497/

Built to branch gh-pages at 2025-04-03 21:05 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

KevLehman
KevLehman previously approved these changes Jan 17, 2025
Copy link
Member

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave the symbolic approve for when this PR is finally opened.

@sampaiodiego sampaiodiego force-pushed the chore-dont-ignore-undefined branch 2 times, most recently from 72a1c10 to 0071ed1 Compare January 22, 2025 18:08
@sampaiodiego sampaiodiego marked this pull request as ready for review January 22, 2025 18:20
@sampaiodiego sampaiodiego requested review from a team as code owners January 22, 2025 18:20
@sampaiodiego sampaiodiego modified the milestones: 7.2.1, 7.3.0, 7.4.0 Jan 22, 2025
ggazzo
ggazzo previously approved these changes Jan 23, 2025
KevLehman
KevLehman previously approved these changes Jan 23, 2025
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging I suggest we double check every query that uses the $exists operator to ensure that it's not checking for something that will start existing as undefined.

@sampaiodiego sampaiodiego force-pushed the chore-dont-ignore-undefined branch from ff4db20 to da28e8f Compare April 3, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants