Skip to content

fix: showButton null condition #6476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
diegolmello merged 1 commit into from
Jul 2, 2025
Merged

fix: showButton null condition #6476

diegolmello merged 1 commit into from
Jul 2, 2025

Conversation

@diegolmello
Copy link
Member

@diegolmello diegolmello commented Jul 2, 2025

Proposed changes

RocketChat/Rocket.Chat#31497 started to return as null settings that used to return undefined.

Issue(s)

Closes #6412
https://rocketchat.atlassian.net/browse/NATIVE-928

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello marked this pull request as ready for review July 2, 2025 17:45
@diegolmello diegolmello force-pushed the fix.login-service-show-button branch from d3c8a14 to 7068a7f Compare July 2, 2025 17:58
OtavioStasiak
OtavioStasiak approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@diegolmello diegolmello force-pushed the fix.login-service-show-button branch from 7068a7f to 5cce0ef Compare July 2, 2025 19:39
@diegolmello diegolmello merged commit 3e47484 into develop Jul 2, 2025
5 of 7 checks passed
@diegolmello diegolmello deleted the fix.login-service-show-button branch July 2, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OtavioStasiak OtavioStasiak OtavioStasiak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: iOS not showing OIDC Login Button

3 participants

@diegolmello @OtavioStasiak