Skip to content

chore: move mention-user-not-in-channel to afterSaveMessage - #31263

Merged
kodiakhq[bot] merged 1 commit into
developfrom
chore-move-bot-mention-code-to-after-save-callback
Dec 18, 2023
Merged

chore: move mention-user-not-in-channel to afterSaveMessage#31263
kodiakhq[bot] merged 1 commit into
developfrom
chore-move-bot-mention-code-to-after-save-callback

Conversation

@sampaiodiego

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Moved the recently added code from #30464 to an afterSaveMessage callback, which doesn't change anything from a feature point of view..

I've also improved the code a little bit removing unnecessary calls to DB.

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot

changeset-bot Bot commented Dec 18, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cc05ee8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 18, 2023
@codecov

codecov Bot commented Dec 18, 2023

Copy link
Copy Markdown

Codecov Report

Merging #31263 (cc05ee8) into develop (ca2f4c5) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31263      +/-   ##
===========================================
- Coverage    49.33%   49.31%   -0.02%     
===========================================
  Files         3299     3299              
  Lines        81080    81079       -1     
  Branches     16554    16553       -1     
===========================================
- Hits         40000    39986      -14     
- Misses       36427    36441      +14     
+ Partials      4653     4652       -1     
Flag Coverage Δ
e2e 52.62% <ø> (-0.03%) ⬇️
e2e-api 40.66% <33.33%> (-0.02%) ⬇️
unit 76.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq
kodiakhq Bot merged commit 56981d8 into develop Dec 18, 2023
@kodiakhq
kodiakhq Bot deleted the chore-move-bot-mention-code-to-after-save-callback branch December 18, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants