Skip to content

refactor: Conversations Overview Analytics - #31217

Merged
kodiakhq[bot] merged 8 commits into
developfrom
fix/busiest-time
Dec 13, 2023
Merged

refactor: Conversations Overview Analytics#31217
kodiakhq[bot] merged 8 commits into
developfrom
fix/busiest-time

Conversation

@KevLehman

@KevLehman KevLehman commented Dec 12, 2023

Copy link
Copy Markdown
Member

SUP-433

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Also fixes a problem with Busiest Time/Day calculation

@changeset-bot

changeset-bot Bot commented Dec 12, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 622c679

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Dec 12, 2023

Copy link
Copy Markdown

Codecov Report

Merging #31217 (622c679) into develop (fae558b) will decrease coverage by 28.49%.
The diff coverage is 78.57%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #31217       +/-   ##
============================================
- Coverage    77.38%   48.89%   -28.49%     
============================================
  Files          276     3270     +2994     
  Lines         8715    80305    +71590     
  Branches      1607    16389    +14782     
============================================
+ Hits          6744    39269    +32525     
- Misses        1565    36382    +34817     
- Partials       406     4654     +4248     
Flag Coverage Δ
e2e 51.35% <ø> (∅)
e2e-api 40.71% <76.47%> (?)
unit 77.36% <77.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman changed the title Fix/busiest time refactor: Overview Analytics Dec 12, 2023
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 12, 2023
@dionisio-bot dionisio-bot Bot removed the stat: ready to merge PR tested and approved waiting for merge label Dec 12, 2023
@KevLehman
KevLehman marked this pull request as ready for review December 13, 2023 14:50
@KevLehman
KevLehman requested a review from a team as a code owner December 13, 2023 14:50
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Dec 13, 2023
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Dec 13, 2023
@KevLehman KevLehman changed the title refactor: Overview Analytics refactor: Conversations Overview Analytics Dec 13, 2023
@kodiakhq
kodiakhq Bot merged commit b8e1c81 into develop Dec 13, 2023
@kodiakhq
kodiakhq Bot deleted the fix/busiest-time branch December 13, 2023 15:39
gabriellsh added a commit that referenced this pull request Dec 13, 2023
…/emailEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat:
  chore: `Field` normalization (#31182)
  refactor: `Conversations` Overview Analytics (#31217)
  fix: Notifications for thread messages are sent even after thread has been read (#31181)
  ci: remove carryforward from codecov (#31216)
  fix: Wrong sysmessage when resuming chat from on hold (#31205)
  fix: Gallery not working inside threads (#31213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants