regression: Gallery not working inside threads - #31213
Merged
Merged
Conversation
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #31213 +/- ##
===========================================
+ Coverage 57.88% 58.58% +0.70%
===========================================
Files 886 1753 +867
Lines 20290 33941 +13651
Branches 3783 7020 +3237
===========================================
+ Hits 11744 19885 +8141
- Misses 7845 12490 +4645
- Partials 701 1566 +865
Flags with carried forward coverage won't be shown. Click here to find out more. |
juliajforesti
previously approved these changes
Dec 12, 2023
tassoevan
approved these changes
Dec 12, 2023
dionisio-bot
Bot
added
the
stat: ready to merge
dionisio-bot
Bot
added
stat: ready to merge
ggazzo
changed the title
dionisio-bot
Bot
removed
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Dec 13, 2023
…/emailEmoji * 'develop' of github.com:RocketChat/Rocket.Chat: chore: `Field` normalization (#31182) refactor: `Conversations` Overview Analytics (#31217) fix: Notifications for thread messages are sent even after thread has been read (#31181) ci: remove carryforward from codecov (#31216) fix: Wrong sysmessage when resuming chat from on hold (#31205) fix: Gallery not working inside threads (#31213)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
TC-1057
Steps to test or reproduce
Send an image
Create a new thread on that image
Inside the thread view, click the image.
It should open the gallery
Further comments