Skip to content

fix: Visitor message not being sent to webhook - #30933

Merged
kodiakhq[bot] merged 7 commits into
RocketChat:developfrom
ldebowczyk:fix/visitor-message-webhook-omnichanel
Nov 20, 2023
Merged

fix: Visitor message not being sent to webhook#30933
kodiakhq[bot] merged 7 commits into
RocketChat:developfrom
ldebowczyk:fix/visitor-message-webhook-omnichanel

Conversation

@ldebowczyk

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

  1. Configure webhook to be called on visitor message
  2. Send message from omnichanel widget

Further comments

@ldebowczyk
ldebowczyk requested a review from a team as a code owner November 12, 2023 20:01
@changeset-bot

changeset-bot Bot commented Nov 12, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 461e17f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant

CLAassistant commented Nov 12, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ldebowczyk ldebowczyk changed the title Fixed problem of no webhook call on visitor message fix: problem of no webhook call on visitor message Nov 12, 2023
@ldebowczyk ldebowczyk changed the title fix: problem of no webhook call on visitor message fix: problem of no webhook call on visitor message via omnichannel Nov 12, 2023
@MartinSchoeler
MartinSchoeler self-requested a review November 13, 2023 12:50
@codecov

codecov Bot commented Nov 13, 2023

Copy link
Copy Markdown

Codecov Report

Merging #30933 (461e17f) into develop (50ab48c) will decrease coverage by 0.42%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30933      +/-   ##
===========================================
- Coverage    51.42%   51.00%   -0.42%     
===========================================
  Files          814      809       -5     
  Lines        15046    15175     +129     
  Branches      2732     2818      +86     
===========================================
+ Hits          7737     7740       +3     
- Misses        6902     6995      +93     
- Partials       407      440      +33     
Flag Coverage Δ
e2e 48.00% <ø> (-0.47%) ⬇️
unit 65.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman changed the title fix: problem of no webhook call on visitor message via omnichannel fix: Visitor message not being sent to webhook Nov 13, 2023
@KevLehman

Copy link
Copy Markdown
Member

Hey! Thanks for your contribution :)

Wanna take a look at the contributor license agreement? That's a requirement for all new contributors

Follow the instructions from the CLAssistant bot over there, thx!

@ldebowczyk

Copy link
Copy Markdown
Contributor Author

Hi,
Is there anything blocking to merge this PR?

@ldebowczyk ldebowczyk closed this Nov 19, 2023
@ldebowczyk ldebowczyk reopened this Nov 19, 2023
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 20, 2023
@kodiakhq
kodiakhq Bot merged commit 6000b63 into RocketChat:develop Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants