Skip to content

fix: Visitor message not being sent to webhook #30933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 7 commits into from
Nov 20, 2023
Merged

fix: Visitor message not being sent to webhook #30933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a27e546
Fixed problem of no webhook call on visitor message
ldebowczyk Nov 12, 2023
895db32
Merge branch 'develop' into fix/visitor-message-webhook-omnichanel
MartinSchoeler Nov 13, 2023
9ae4c5e
Create loud-foxes-grin.md
KevLehman Nov 13, 2023
1869bae
Merge branch 'develop' into fix/visitor-message-webhook-omnichanel
ldebowczyk Nov 13, 2023
24d43c9
Merge branch 'develop' into fix/visitor-message-webhook-omnichanel
ldebowczyk Nov 13, 2023
7784ea1
Merge branch 'fix/visitor-message-webhook-omnichanel' of https://gith…
ldebowczyk Nov 13, 2023
461e17f
Merge branch 'develop' into fix/visitor-message-webhook-omnichanel
MartinSchoeler Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/loud-foxes-grin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

fix: Visitor message not being sent to webhook due to wrong validation of settings
2 changes: 1 addition & 1 deletion apps/meteor/app/livechat/server/hooks/sendToCRM.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ callbacks.add(
if (message.token && !settings.get('Livechat_webhook_on_visitor_message')) {
return message;
}
if (!settings.get('Livechat_webhook_on_agent_message')) {
if (!message.token && !settings.get('Livechat_webhook_on_agent_message')) {
return message;
}
// if the message has a type means it is a special message (like the closing comment), so skips
Expand Down