fix: File attachments have no content when exporting room messages as file - #30596
Merged
Conversation
🦋 Changeset detectedLatest commit: 774b2ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #30596 +/- ##
===========================================
- Coverage 51.28% 51.27% -0.02%
===========================================
Files 811 804 -7
Lines 15078 15107 +29
Branches 2754 2768 +14
===========================================
+ Hits 7733 7746 +13
+ Misses 6935 6933 -2
- Partials 410 428 +18
Flags with carried forward coverage won't be shown. Click here to find out more. |
heitortanoue
approved these changes
Oct 9, 2023
dionisio-bot
Bot
added
the
stat: ready to merge
dionisio-bot
Bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Oct 16, 2023
…/mentionBot * 'develop' of github.com:RocketChat/Rocket.Chat: feat: add tooltip to badge mentions (#30590) chore: improve `Tag` a11y link (#30636) refactor: Replace `useForm` in favor of RHF on `AppInstallPage` (#30634) fix: Improve FileProxy Handling, set Content-Type (#30427) refactor: `EditRoomInfo` to typescript (#28318) fix: mobile ringing notification missing call id (#30614) fix: Some HTTP requests sent by apps don't have their data parsed into JSON (#30560) test: More tests for groups kick (#30536) fix: Threads breaking after sending messages too fast (#30622) chore: Remove text decoration from room tag (#30606) i18n: Language update from LingoHub 🤖 on 2023-10-10Z (#30613) fix: File attachments have no content when exporting room messages as file (#30596) fix: use setImmediate to handle username update (#30500) chore: `AnalyticsReports` visual adequacy (#30617)
debdutdeb
pushed a commit
that referenced
this pull request
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Expected behavior: the attachments should be available inside the assets directory, and all of their content should be visible just as in RC.
Current behavior: all files are created and available in the assets directory, but they have no content (file sizes are all zero).
Further comments
SUP-358