fix: do not broadcast events from the local node to the local service (duplicated event) #30446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (duplicated event)
🦋 Changeset detectedLatest commit: 464dce3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #30446 +/- ##
===========================================
- Coverage 50.23% 50.02% -0.22%
===========================================
Files 780 772 -8
Lines 14477 14425 -52
Branches 2617 2610 -7
===========================================
- Hits 7273 7216 -57
+ Misses 6809 6801 -8
- Partials 395 408 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
approved these changes
Sep 22, 2023
gabriellsh
added a commit
that referenced
this pull request
Sep 27, 2023
…ove/iframeLogin * 'develop' of github.com:RocketChat/Rocket.Chat: (33 commits) feat: New records page analytics tab (#30373) chore: Changing some key translations - Setup Wizard (#30462) feat: use isolated-vm to run integration scripts (#30229) fix: do not broadcast events from the local node to the local service (duplicated event) (#30446) fix: Microsoft autotranslate not working (#30390) chore: `ResetPasswordPage` a11y improvements (#30479) chore: `ResetPasswordForm` a11y improvements (#30476) chore: Move bad words filter callback to service (#30241) fix: Message disappears from room after deletion even if "Show Deleted Status" is enabled (#30452) chore: add tooltip to mentions (#30445) chore: bump mongo deps (#30450) ci: patch mongo type definitions (#30449) chore: cache incremental ts check (#30447) Release 6.4.0-rc.4 Release 6.4.0-rc.3 chore: update meteor 2.13.0 (#29989) chore: Assertion accuracy on registration test (#30440) ci: Add step to notify external services about a new release after Docker image publish (#30436) regression: close button not working on contact history (#30432) regression: custom fields not showing in current chats (#30428) ...
gabriellsh
added a commit
that referenced
this pull request
Sep 28, 2023
…/mentionBot * 'develop' of github.com:RocketChat/Rocket.Chat: chore: move Omnichannel toolbox section from sidebar room list (#30502) fix: RTL lang crashes Moderation Console (#30393) feat: New records page analytics tab (#30373) chore: Changing some key translations - Setup Wizard (#30462) feat: use isolated-vm to run integration scripts (#30229) fix: do not broadcast events from the local node to the local service (duplicated event) (#30446) fix: Microsoft autotranslate not working (#30390) chore: `ResetPasswordPage` a11y improvements (#30479) chore: `ResetPasswordForm` a11y improvements (#30476) chore: Move bad words filter callback to service (#30241) fix: Message disappears from room after deletion even if "Show Deleted Status" is enabled (#30452) chore: add tooltip to mentions (#30445)
debdutdeb
pushed a commit
that referenced
this pull request
Oct 26, 2023
… (duplicated event) (#30446)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments