fix: RTL lang crashes Moderation Console #30393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
debdutdeb
reviewed
Sep 14, 2023
Codecov Report
@@ Coverage Diff @@
## develop #30393 +/- ##
===========================================
- Coverage 50.23% 50.21% -0.03%
===========================================
Files 780 775 -5
Lines 14476 14459 -17
Branches 2617 2613 -4
===========================================
- Hits 7272 7260 -12
+ Misses 6809 6790 -19
- Partials 395 409 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
AlenDavid
approved these changes
Sep 14, 2023
Contributor
AlenDavid
left a comment
AlenDavid
left a comment
There was a problem hiding this comment.
Looks good to me already.
csuadev
approved these changes
Sep 26, 2023
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Sep 28, 2023
…/mentionBot * 'develop' of github.com:RocketChat/Rocket.Chat: chore: move Omnichannel toolbox section from sidebar room list (#30502) fix: RTL lang crashes Moderation Console (#30393) feat: New records page analytics tab (#30373) chore: Changing some key translations - Setup Wizard (#30462) feat: use isolated-vm to run integration scripts (#30229) fix: do not broadcast events from the local node to the local service (duplicated event) (#30446) fix: Microsoft autotranslate not working (#30390) chore: `ResetPasswordPage` a11y improvements (#30479) chore: `ResetPasswordForm` a11y improvements (#30476) chore: Move bad words filter callback to service (#30241) fix: Message disappears from room after deletion even if "Show Deleted Status" is enabled (#30452) chore: add tooltip to mentions (#30445)
ggazzo
pushed a commit
that referenced
this pull request
Sep 28, 2023
debdutdeb
pushed a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
new Date().toISOString()only accepting theenlocale date formatsIssue(s)
Steps to test or reproduce
Further comments
AECO-385