Skip to content

fix: warning message for /matrixIds when start - #30104

Merged
lmauromb merged 2 commits into
fix/fed-116from
fix/federation-matrixIds-endpoint
Oct 27, 2023
Merged

fix: warning message for /matrixIds when start#30104
lmauromb merged 2 commits into
fix/fed-116from
fix/federation-matrixIds-endpoint

Conversation

@lmauromb

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Fix the warning message of Ajv on the /matrixIds endpoint reported when starting the application

check: ajv-validator/ajv#1632 for the solution

Issue(s)

Issue reported on open:

@rocket.chat/meteor:dsv: W20230816-11:11:57.626(-6)? (STDERR) strict mode: "items" is 1-tuple, but minItems or maxItems/additionalItems are not specified or different at path "#/properties/matrixIds"

Steps to test or reproduce

Start application

@lmauromb
lmauromb requested review from a team as code owners August 16, 2023 19:31
@changeset-bot

changeset-bot Bot commented Aug 16, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 622ab32

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lmauromb lmauromb changed the title fix - warning message for /matrixIds fix: warning message for /matrixIds when start Aug 16, 2023
@codecov

codecov Bot commented Aug 16, 2023

Copy link
Copy Markdown

Codecov Report

Merging #30104 (622ab32) into develop (a363ae3) will increase coverage by 2.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30104      +/-   ##
===========================================
+ Coverage    47.72%   49.83%   +2.11%     
===========================================
  Files          694      731      +37     
  Lines        13097    14298    +1201     
  Branches      2286     2540     +254     
===========================================
+ Hits          6250     7125     +875     
- Misses        6506     6787     +281     
- Partials       341      386      +45     
Flag Coverage Δ
e2e 47.72% <ø> (+0.03%) ⬆️
unit 66.13% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@lmauromb
lmauromb changed the base branch from develop to fix/fed-116 October 27, 2023 01:30
@lmauromb
lmauromb merged commit 7eb4bc0 into fix/fed-116 Oct 27, 2023
@lmauromb
lmauromb deleted the fix/federation-matrixIds-endpoint branch October 27, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants