fix: External avatar url provider for rooms not respected. #28910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tassoevan
requested changes
Apr 13, 2023
Codecov Report
@@ Coverage Diff @@
## develop #28910 +/- ##
===========================================
+ Coverage 43.74% 46.00% +2.25%
===========================================
Files 680 728 +48
Lines 12933 14079 +1146
Branches 2122 2263 +141
===========================================
+ Hits 5658 6477 +819
- Misses 6983 7281 +298
- Partials 292 321 +29
Flags with carried forward coverage won't be shown. Click here to find out more. |
tassoevan
previously approved these changes
Apr 14, 2023
dionisio-bot
bot
added
the
stat: ready to merge
…externalAvatarProvider * 'develop' of github.com:RocketChat/Rocket.Chat: (88 commits) feat: Add support to search for public rooms through the Matrix Network (#28330) chore: Improve bash script and add new detailed infos (#29066) chore: Remove duplicated key in turbo.json (#29057) chore: improve unread indicator colors (#29045) fix: Notification badge background (#29053) fix: `JumpToMessages` button style (#29033) refactor: Remove imports based on isomorphic logic - 2 (#29065) refactor: Move `cloud` and `channel settings` to typescript (#28907) refactor: Separate isomorphic imports on utils - 1 (#29052) fix: bug in close method of RoomManager occurs memory leak (#29058) refactor: Remove Meteor.userId from Slashcommands (#28925) refactor: Move callbacks to async (#29051) Bump version to 6.2.0-rc.4 refactor: No reference to jQuery types (#28977) regression: SlackBridge settings UI crashing (#29050) fix: `HeaderTag` (#28961) chore(deps): Patch dependencies (#29024) regression: Fixed livechat notifications displaying [object Promise] on title (#29021) regression: `fetch` response (#29032) refactor: Remove `meteor/http` for `serverFetch` (#29038) ...
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
ggazzo
approved these changes
May 2, 2023
Merged
10 tasks
|
did this feature merge into master branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Closes #28351
Steps to test or reproduce
Admin -> Settings -> Accounts -> Avatar -> Room Avatar External Provider URLAll rooms should have this link as avatar.
Further comments
TC-635