Skip to content

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Apr 25, 2023

DSAR-120

Proposed changes (including videos or screenshots)

  • replace ghost variant in favor of secondary to fix contrast on sidebar notification

from:
image

to:
image

Issue(s)

Steps to test or reproduce

Further comments

@juliajforesti juliajforesti marked this pull request as ready for review April 25, 2023 20:25
@juliajforesti juliajforesti requested a review from a team as a code owner April 25, 2023 20:25
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Apr 26, 2023
@dougfabris dougfabris added this to the 6.3.0 milestone Apr 26, 2023
@dougfabris dougfabris changed the title fix: Notification badge fix: Notification badge background Apr 26, 2023
@ggazzo ggazzo merged commit 75a3a10 into develop Apr 26, 2023
@ggazzo ggazzo deleted the fix/badge-sidebar branch April 26, 2023 20:04
gabriellsh added a commit that referenced this pull request Apr 27, 2023
…ixSearch

* 'develop' of github.com:RocketChat/Rocket.Chat: (54 commits)
  feat: Add support to search for public rooms through the Matrix Network (#28330)
  chore: Improve bash script and add new detailed infos (#29066)
  chore: Remove duplicated key in turbo.json (#29057)
  chore: improve unread indicator colors (#29045)
  fix: Notification badge background (#29053)
  fix: `JumpToMessages` button style (#29033)
  refactor: Remove imports based on isomorphic logic - 2 (#29065)
  refactor: Move `cloud` and `channel settings` to typescript (#28907)
  refactor: Separate isomorphic imports on utils - 1 (#29052)
  fix: bug in close method of RoomManager occurs memory leak (#29058)
  refactor: Remove Meteor.userId from Slashcommands (#28925)
  refactor: Move callbacks to async (#29051)
  Bump version to 6.2.0-rc.4
  refactor: No reference to jQuery types (#28977)
  regression: SlackBridge settings UI crashing (#29050)
  fix: `HeaderTag` (#28961)
  chore(deps): Patch dependencies (#29024)
  regression: Fixed livechat notifications displaying [object Promise] on title (#29021)
  regression: `fetch` response (#29032)
  refactor: Remove `meteor/http` for `serverFetch` (#29038)
  ...
gabriellsh added a commit that referenced this pull request Apr 27, 2023
…externalAvatarProvider

* 'develop' of github.com:RocketChat/Rocket.Chat: (88 commits)
  feat: Add support to search for public rooms through the Matrix Network (#28330)
  chore: Improve bash script and add new detailed infos (#29066)
  chore: Remove duplicated key in turbo.json (#29057)
  chore: improve unread indicator colors (#29045)
  fix: Notification badge background (#29053)
  fix: `JumpToMessages` button style (#29033)
  refactor: Remove imports based on isomorphic logic - 2 (#29065)
  refactor: Move `cloud` and `channel settings` to typescript (#28907)
  refactor: Separate isomorphic imports on utils - 1 (#29052)
  fix: bug in close method of RoomManager occurs memory leak (#29058)
  refactor: Remove Meteor.userId from Slashcommands (#28925)
  refactor: Move callbacks to async (#29051)
  Bump version to 6.2.0-rc.4
  refactor: No reference to jQuery types (#28977)
  regression: SlackBridge settings UI crashing (#29050)
  fix: `HeaderTag` (#28961)
  chore(deps): Patch dependencies (#29024)
  regression: Fixed livechat notifications displaying [object Promise] on title (#29021)
  regression: `fetch` response (#29032)
  refactor: Remove `meteor/http` for `serverFetch` (#29038)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants