Skip to content

Conversation

@KevLehman
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@KevLehman KevLehman requested a review from a team as a code owner April 13, 2023 17:16
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #28907 (d0dd3a5) into develop (37cb94c) will increase coverage by 1.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28907      +/-   ##
===========================================
+ Coverage    44.76%   46.11%   +1.35%     
===========================================
  Files          703      730      +27     
  Lines        13717    14122     +405     
  Branches      2183     2224      +41     
===========================================
+ Hits          6140     6512     +372     
- Misses        7268     7294      +26     
- Partials       309      316       +7     
Flag Coverage Δ
e2e 46.08% <ø> (+1.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 26, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 26, 2023
@ggazzo ggazzo merged commit 3aee94a into develop Apr 26, 2023
@ggazzo ggazzo deleted the refactor/files-ts branch April 26, 2023 19:41
gabriellsh added a commit that referenced this pull request Apr 27, 2023
…ixSearch

* 'develop' of github.com:RocketChat/Rocket.Chat: (54 commits)
  feat: Add support to search for public rooms through the Matrix Network (#28330)
  chore: Improve bash script and add new detailed infos (#29066)
  chore: Remove duplicated key in turbo.json (#29057)
  chore: improve unread indicator colors (#29045)
  fix: Notification badge background (#29053)
  fix: `JumpToMessages` button style (#29033)
  refactor: Remove imports based on isomorphic logic - 2 (#29065)
  refactor: Move `cloud` and `channel settings` to typescript (#28907)
  refactor: Separate isomorphic imports on utils - 1 (#29052)
  fix: bug in close method of RoomManager occurs memory leak (#29058)
  refactor: Remove Meteor.userId from Slashcommands (#28925)
  refactor: Move callbacks to async (#29051)
  Bump version to 6.2.0-rc.4
  refactor: No reference to jQuery types (#28977)
  regression: SlackBridge settings UI crashing (#29050)
  fix: `HeaderTag` (#28961)
  chore(deps): Patch dependencies (#29024)
  regression: Fixed livechat notifications displaying [object Promise] on title (#29021)
  regression: `fetch` response (#29032)
  refactor: Remove `meteor/http` for `serverFetch` (#29038)
  ...
gabriellsh added a commit that referenced this pull request Apr 27, 2023
…externalAvatarProvider

* 'develop' of github.com:RocketChat/Rocket.Chat: (88 commits)
  feat: Add support to search for public rooms through the Matrix Network (#28330)
  chore: Improve bash script and add new detailed infos (#29066)
  chore: Remove duplicated key in turbo.json (#29057)
  chore: improve unread indicator colors (#29045)
  fix: Notification badge background (#29053)
  fix: `JumpToMessages` button style (#29033)
  refactor: Remove imports based on isomorphic logic - 2 (#29065)
  refactor: Move `cloud` and `channel settings` to typescript (#28907)
  refactor: Separate isomorphic imports on utils - 1 (#29052)
  fix: bug in close method of RoomManager occurs memory leak (#29058)
  refactor: Remove Meteor.userId from Slashcommands (#28925)
  refactor: Move callbacks to async (#29051)
  Bump version to 6.2.0-rc.4
  refactor: No reference to jQuery types (#28977)
  regression: SlackBridge settings UI crashing (#29050)
  fix: `HeaderTag` (#28961)
  chore(deps): Patch dependencies (#29024)
  regression: Fixed livechat notifications displaying [object Promise] on title (#29021)
  regression: `fetch` response (#29032)
  refactor: Remove `meteor/http` for `serverFetch` (#29038)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants