[FIX] Livechat Agents & monitors not able to pick up chats from queue #24541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murtaza98
commented
Feb 18, 2022
murtaza98
commented
Feb 18, 2022
murtaza98
commented
Feb 18, 2022
KevLehman
requested changes
Feb 18, 2022
| const inquiry = Template.instance().inquiry.get(); | ||
| const room = Template.instance().room.get(); | ||
| return (inquiry && inquiry.status === 'queued') || !room.servedBy; | ||
| return inquiry && inquiry.status === 'queued'; |
Member
There was a problem hiding this comment.
I've gotta say: this works. this won't solve other room-related issues when some room props are updated (like room's name/visibility) but will solve our use case so we should be fine for now.
I'll create a task to address the bigger one.
| }); | ||
| if (!userCanTakeInquiry(user)) { | ||
| throw new Meteor.Error('error-not-allowed', 'Not allowed', { | ||
| throw new Meteor.Error('error-not-allowed-due-to-offline', `Not allowed since user's status is offline`, { |
Member
There was a problem hiding this comment.
Is it true that the only reason for not being able to take the inquiry is because the user is offline? 👀
| 'cant-join-room', | ||
| ); | ||
|
|
||
| callbacks.add( |
Member
There was a problem hiding this comment.
Do this callback needs to be inside a Meteor.startup? Can be on its own ts file and imported on this one? 👀
Additionally, can you add this callback signature to the callback types? (on lib/callbacks.ts)
| callbacks.add( | ||
| 'beforeJoinRoom', | ||
| function (user, room) { | ||
| if (room.t === 'l' && !room.servedBy) { |
Member
There was a problem hiding this comment.
- You can use the
isOmnichannelRoomfunction to check if the room is an omnichannel room. - Change the sense of the if so that if the room is not livechat or the room is already assigned you return the user, so the code can be unnested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Monitor|Agent can't take the actual chat by pressing the "Take It" button.
Steps to test or reproduce
Expected Behavior:
Be able to send messages after clicking on the "Take it" button
Actual Behavior:
A warning says "Not permitted" after clicking the button
Further comments
Sidenote from an implementation perspective: In this new PR, we've modified the logic in a way that reverses the changes done here (where this issue was actually introduced) but still fixes the issue in that PR (i.e. Closed chats doesn't show who picked the call) by listening to the "beforeJoinRoom" hook & automatically assign the manager/monitor to the chat, in case no agent is assigned to the chat at that point