Fix Closed chats doesn't shows who picked the call #22368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatobecker
requested changes
Jun 16, 2021
renatobecker
requested changes
Jun 16, 2021
murtaza98
commented
Jun 17, 2021
…t/Rocket.Chat into omnichannel/improve-chat-take-it-option
renatobecker
approved these changes
Jun 18, 2021
ggazzo
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Fix Closed chats doesn't shows who picked the call * remove all subscriptions of a room once the chat is forwarded or moved back to queue * Show 'Take It' button if the room does not have the serving agent * remove unncessary condition * update conditions * apply suggestions from code review * Apply suggestions from code review * convert Subscriptions.insertOrUpsert to Subscriptions.insert * Improve condition Co-authored-by: Tiago Evangelista Pinto <[email protected]>
ggazzo
pushed a commit
that referenced
this pull request
Jun 25, 2021
* Fix Closed chats doesn't shows who picked the call * remove all subscriptions of a room once the chat is forwarded or moved back to queue * Show 'Take It' button if the room does not have the serving agent * remove unncessary condition * update conditions * apply suggestions from code review * Apply suggestions from code review * convert Subscriptions.insertOrUpsert to Subscriptions.insert * Improve condition Co-authored-by: Tiago Evangelista Pinto <[email protected]>
ggazzo
pushed a commit
that referenced
this pull request
Jun 25, 2021
* Fix Closed chats doesn't shows who picked the call * remove all subscriptions of a room once the chat is forwarded or moved back to queue * Show 'Take It' button if the room does not have the serving agent * remove unncessary condition * update conditions * apply suggestions from code review * Apply suggestions from code review * convert Subscriptions.insertOrUpsert to Subscriptions.insert * Improve condition Co-authored-by: Tiago Evangelista Pinto <[email protected]>
ggazzo
pushed a commit
that referenced
this pull request
Jun 25, 2021
* Fix Closed chats doesn't shows who picked the call * remove all subscriptions of a room once the chat is forwarded or moved back to queue * Show 'Take It' button if the room does not have the serving agent * remove unncessary condition * update conditions * apply suggestions from code review * Apply suggestions from code review * convert Subscriptions.insertOrUpsert to Subscriptions.insert * Improve condition Co-authored-by: Tiago Evangelista Pinto <[email protected]>
MartinSchoeler
pushed a commit
that referenced
this pull request
Jun 25, 2021
* Fix Closed chats doesn't shows who picked the call * remove all subscriptions of a room once the chat is forwarded or moved back to queue * Show 'Take It' button if the room does not have the serving agent * remove unncessary condition * update conditions * apply suggestions from code review * Apply suggestions from code review * convert Subscriptions.insertOrUpsert to Subscriptions.insert * Improve condition Co-authored-by: Tiago Evangelista Pinto <[email protected]>
MartinSchoeler
pushed a commit
that referenced
this pull request
Jun 25, 2021
* Fix Closed chats doesn't shows who picked the call * remove all subscriptions of a room once the chat is forwarded or moved back to queue * Show 'Take It' button if the room does not have the serving agent * remove unncessary condition * update conditions * apply suggestions from code review * Apply suggestions from code review * convert Subscriptions.insertOrUpsert to Subscriptions.insert * Improve condition Co-authored-by: Tiago Evangelista Pinto <[email protected]>
MartinSchoeler
pushed a commit
that referenced
this pull request
Jun 28, 2021
* Fix Closed chats doesn't shows who picked the call * remove all subscriptions of a room once the chat is forwarded or moved back to queue * Show 'Take It' button if the room does not have the serving agent * remove unncessary condition * update conditions * apply suggestions from code review * Apply suggestions from code review * convert Subscriptions.insertOrUpsert to Subscriptions.insert * Improve condition Co-authored-by: Tiago Evangelista Pinto <[email protected]>
gabriellsh
added a commit
that referenced
this pull request
Jul 1, 2021
…ite/create_disc * 'develop' of github.com:RocketChat/Rocket.Chat: (27 commits) [IMPROVE] Preview message URLs only once (#22516) [FIX] Admin page crashing when commit hash is null (#22057) [FIX] Unnecessary space on members list footer (#22514) Chore: Review some dependencies (#22522) Chore: Meteor 2.2 and bump dependencies (#22399) Chore: Remove Sodium from the main client (#22459) [FIX] Prune messages from particular user(s) (#22506) [FIX] Livechat apps permission error (#22511) [IMPROVE] Message deletion modal #22508 Update README.md Update README.md [IMPROVE] Add pagination to tags, and improve current Agents pagination [FIX] Rewrite CurrentChats to TS (#22424) [FIX] Sort AutocompleteDepartmentsMultiple (#22419) [FIX] Put title into AutocompleteDepartment components (#22417) [FIX] Bugs in AutoCompleteDepartment (#22414) [FIX] Closed chats doesn't show who picked the call (#22368) [FIX] Omnichannel Real Time Monitoring chart not displaying chats-per-agent and chats-per-department (#22406) [IMPROVE] Paginated multiselect for EE tags (#22315) [FIX] Units Edit and adds the option to hide own department in useDepartmentList ...
Merged
KevLehman
reviewed
Dec 16, 2021
| const inquiry = Template.instance().inquiry.get(); | ||
| return inquiry && inquiry.status === 'queued'; | ||
| const room = Template.instance().room.get(); | ||
| return (inquiry && inquiry.status === 'queued') || !room.servedBy; |
Member
There was a problem hiding this comment.
Hey Murtaza, I know this is an old PR, but, would you mind explaining me this change? 👀
I just want to know what's fixing, since I'm looking at a related issue and wanted to understand why this was needed
Contributor
Author
There was a problem hiding this comment.
Hey, @KevLehman This change was needed to ensure that we show the Take It button on the chat if there are no agents assigned to a chat yet.
Before this change, we were only showing that button if the "Manual Selection" algorithm was on. However, we ran into a situation (on servers running other algorithms than manual) where LiveChat managers were using the "Current Chats" panel to send messages to unassigned chats - this resulted in chats that were actually answered but not assigned to any agents - since the manually answered those chats and didn't get the routing algorithm involved.
Hence we added a new rule here where we decided that if any manager wants to answer an unassigned chat, then they'd first have to "Take it" ..... Hence I added this new condition here - !room.servedBy.
Let me know if you need any further help with this 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Clickup task: https://app.clickup.com/t/5999dv
Steps to test or reproduce
Further comments