[FIX] Don't use global search by default #20597
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sampaiodiego could you please take a look. I believe this was due to an uncovered case in this |
Contributor
Author
|
@sampaiodiego what do you think? Looks good? |
|
Any chance this gets pushed as it's an annoying quirk. |
|
|
|
Waiting this PR to be merged almost a year now... |
Member
|
Hi there, thanks for the contribution! 🚀 💯 Closing this PR because it's stale now and it was already fixed here: #25568 Questions? Help needed? Feature Requests?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Disabling just the checkbox as done here isn't the complete solution since even if the checkbox is disabled the
searchAllproperty is set totruewhen the global search is enabled from the administration panel.An additional change to not use global search by default is to not set the
searchAllproperty by default.After Fix
Screencast.from.Thursday.04.February.2021.12.48.20.IST.mp4
Issue(s)
Fixes #20595
Steps to test or reproduce