Skip to content

[FIX] "Add reaction" icon missing when the viewport size is smaller than 500px #18110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rodrigok merged 3 commits into from
Jul 2, 2020
Merged

[FIX] "Add reaction" icon missing when the viewport size is smaller than 500px #18110

rodrigok merged 3 commits into from
Jul 2, 2020

Conversation

@dudizilla
Copy link
Contributor

@dudizilla dudizilla commented Jul 1, 2020

Proposed changes

Issue(s)

closes #18069

How to test or reproduce

Screenshots

Types of changes

  • [ X ] Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • [ X ] I have read the CONTRIBUTING doc
  • [ X ] I have signed the CLA
  • [ X ] Lint and unit tests pass locally with my changes
  • [ X ] I have added tests that prove my fix is effective or that my feature works (if applicable)
  • [ X ] I have added necessary documentation (if applicable)
  • [ X ] Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@rodrigok rodrigok added this to the 3.4.1 milestone Jul 1, 2020
@rodrigok rodrigok changed the title [FIX] Removing .message media-query. Now add-reaction appears when viewport is smaller than 500px [FIX] "Add reaction" icon missing when the viewport size is smaller than 500px Jul 1, 2020
MartinSchoeler
MartinSchoeler approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rodrigok rodrigok merged commit f96c9a1 into develop Jul 2, 2020
@rodrigok rodrigok deleted the removing-media-query branch July 2, 2020 21:26
sampaiodiego pushed a commit that referenced this pull request Jul 2, 2020
@dudizilla @sampaiodiego
[FIX] "Add reaction" icon missing when the viewport size is smaller t…
55ffa8b 
…han 500px (#18110)
@sampaiodiego sampaiodiego mentioned this pull request Jul 2, 2020
Merged
gabriellsh added a commit that referenced this pull request Jul 6, 2020
@gabriellsh
Merge branch 'rewrite/accounts' of github.com:RocketChat/Rocket.Chat …
6658070 
…into new/rewrite_account_profile

* 'rewrite/accounts' of github.com:RocketChat/Rocket.Chat:
  [FIX] Cannot open admin when server uses ROOT_URL with subpath (#18105) (#18147)
  [FIX] App details returns to apps table, instead of previous page (#18080)
  [FIX] Clipboard not working when permalinking a pinned message (#18047)
  [FIX] "Add reaction" icon missing when the viewport size is smaller than 500px (#18110)
  [FIX] Jitsi opening twice (#18111)
  [FIX] Email notifications were still being sent for online users (#18088)
  [FIX] The livechat agent activity monitor wasn't being initialised because due to an internal error (#18090)
gabriellsh added a commit that referenced this pull request Jul 6, 2020
@gabriellsh
Merge branch 'new/rewrite_account_profile' of github.com:RocketChat/R…
87f27ca 
…ocket.Chat into rewrite/user_preferences

* 'new/rewrite_account_profile' of github.com:RocketChat/Rocket.Chat:
  [FIX] Cannot open admin when server uses ROOT_URL with subpath (#18105) (#18147)
  [FIX] App details returns to apps table, instead of previous page (#18080)
  [FIX] Clipboard not working when permalinking a pinned message (#18047)
  [FIX] "Add reaction" icon missing when the viewport size is smaller than 500px (#18110)
  [FIX] Jitsi opening twice (#18111)
  [FIX] Email notifications were still being sent for online users (#18088)
  [FIX] The livechat agent activity monitor wasn't being initialised because due to an internal error (#18090)
ggazzo added a commit that referenced this pull request Jul 28, 2020
@sampaiodiego @ggazzo
@dudizilla @gabriellsh @renatobecker @rodrigok @paulobernardoaf @Densik @omarchehab98 @pierre-lehnen-rc
Merge master into develop & Set version to 3.6.0-develop (#18401)
9b49a44 
* [FIX] Jitsi opening twice (#18111)

* [FIX] "Add reaction" icon missing when the viewport size is smaller than 500px (#18110)

* [FIX] Avatar ETag missing from User (#18109)

* Handle callback returning promise. (#18102)

* [FIX] Not possible to read encrypted messages after disable E2E on channel level (#18101)

* [FIX] The livechat agent activity monitor wasn't being initialised because due to an internal error (#18090)

* [FIX] Email notifications were still being sent for online users (#18088)

* Bump version to 3.4.1

* [FIX] App details returns to apps table, instead of previous page (#18080)

* [FIX] Cannot open admin when server uses ROOT_URL with subpath (#18105) (#18147)

* [FIX] Old Data Migrations breaking upgrades (#18185)

* [FIX] Application not loading due to reverse proxy decoding API calls unnecessarily (#18222)

* [FIX] SAML login crashing when receiving an array of roles (#18224)

* [FIX] CAS login not merging users with local accounts (#18238)

* Bump version to 3.4.2

* Bump version to 3.5.0-rc.0

* Bump version to 3.5.0-rc.1

* Bump version to 3.5.0-rc.2

* Bump version to 3.5.0-rc.3

* Bump version to 3.5.0-rc.4

* Bump version to 3.5.0

* Bump version to 3.6.0-develop

Co-authored-by: Guilherme Gazzo <[email protected]>
Co-authored-by: Maria Eduarda Cunha <[email protected]>
Co-authored-by: gabriellsh <[email protected]>
Co-authored-by: Renato Becker <[email protected]>
Co-authored-by: Rodrigo Nascimento <[email protected]>
Co-authored-by: Paulo Bernardo <[email protected]>
Co-authored-by: Denis <[email protected]>
Co-authored-by: Omar Chehab <[email protected]>
Co-authored-by: pierre-lehnen-rc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinSchoeler MartinSchoeler MartinSchoeler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.4.1

Development

Successfully merging this pull request may close these issues.

Add reaction icon missing when the viewport/iframe size is smaller than the default chrome ones.

4 participants

@dudizilla @MartinSchoeler @rodrigok