-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for IPOPT on Mac by pinning to a specific GCC version. #4970
Add support for IPOPT on Mac by pinning to a specific GCC version. #4970
Conversation
Sure. BTW, I don't see the reviewable link here. |
Never mind. Just created! |
Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion. a discussion (no related file):
Comments from Reviewable |
Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion. a discussion (no related file): Previously, soonho-tri (Soonho Kong) wrote…
On another mac, it works well. Comments from Reviewable |
Yeah, sorry, I also am having difficulties after making changes based on the Slack conversation. Stay tuned. |
No need to sorry at all. Thanks a lot for the hard work!! Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. Comments from Reviewable |
This makes it possible to locate the Fortran libraries.
97c9b95
to
7beb37c
Compare
Jenkins build failed |
I'm closing this - @jwnimmer-tri has made a better suggestion, namely to use a repository rule. I'd somehow forgotten repository rules could capture shell command outputs. |
Jenkins build failed |
Jenkins build passed |
This makes it possible to locate
libgfortran.a
on Mac, since Homebrew doesn't install or symlink it to a canonical location. It would be much better to usepkg-config
, but Homebrew doesn't install a .pc file. It would also be much better to interrogategfortran
directly, as IPOPT itself does, but Bazel apparently provides no mechanism to use the results of a shell command as linker arguments to acc_library
rule.@soonho-tri for feature review; could you test locally please?
@jamiesnape @BetsyMcPhail The OS X images in CI should be updated to pin gcc 5.4, instead of tracking the head of gcc. Aside and apart from the Bazel issue, I think it's saner to use a version of gfortran on Mac that's consistent with the project's other uses of gcc.
Also, if anyone knows of a way to make
brew pin
more precise, that would be great.This change is