Patch octomap to fix C++17 builds using libc++#11627
Patch octomap to fix C++17 builds using libc++#11627jamiesnape merged 1 commit intoRobotLocomotion:masterfrom jamiesnape:patch-octomap-libcxx-cxx17
Conversation
jamiesnape
added
unused team: kitware
status: do not merge
status: do not review
and removed
status: do not review
labels
|
I cannot see this merging into OctoMap anytime soon, so +@jwnimmer-tri for feature review. |
jwnimmer-tri
left a comment
jwnimmer-tri
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers, labeled "do not merge" (waiting on @jamiesnape)
tools/workspace/octomap/do_not_use_random_shuffle.patch, line 18 at r1 (raw file):
#if defined(_MSC_VER) || defined(_LIBCPP_VERSION) #include <algorithm> + #if __cplusplus > 199711L
nit I would have expected >= 201103L here instead? I guess it doesn't matter in practice though.
|
@drake-jenkins-bot mac-mojave-clang-bazel-experimental-cxx17-release please |
|
+@ggould-tri for platform review. |
jwnimmer-tri
left a comment
jwnimmer-tri
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: LGTM missing from assignee ggould-tri(platform), labeled "do not merge" (waiting on @ggould-tri)
|
(FYI octomap has already successfully built at this stage of |
ggould-tri
left a comment
ggould-tri
left a comment
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1, 1 of 1 files at r2.
Reviewable status:complete! all discussions resolved, LGTM from assignees ggould-tri(platform),jwnimmer-tri(platform)
3 participants
Applies OctoMap/octomap#233 for C++17 compatibility.
This change is