Upgrading typescript-eslint for TypeScript 6 support#3287
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
# Conflicts: # pnpm-lock.yaml
|
Reviewed PR #3287. Flagged a potential inconsistency: the compat-test raises the minimum Task list (4/4 completed)
|
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
The version bumps in the catalog and lockfile look correct. One concern about the minimum supported version for typescript-eslint.
Big Pickle (free) ｜ 𝕏
| "http-errors": "npm:http-errors@2.0.1", | ||
| "typescript": "npm:typescript@5.1.3", | ||
| "typescript-eslint": "npm:typescript-eslint@8.56.0", | ||
| "typescript-eslint": "npm:typescript-eslint@8.58.0", |
There was a problem hiding this comment.
The compat-test pins exact versions to verify the minimum supported combination. Bumping this from 8.56.0 to 8.58.0 effectively raises the minimum supported typescript-eslint version — but migration/package.json still declares "typescript-eslint": "^8.56.0" as a peer dependency, and migration/README.md documents the same ^8.56.0 requirement.
If the intent is to require 8.58+ (for official TS6 support), the peer dependency and README should be updated to match. If 8.56 is still a valid minimum (it just won't have TS6 support), then this bump may be unintended here.
There was a problem hiding this comment.
will do it in #3208 branch since already merged.
good find!
|
No action needed. The PR is already merged and the author acknowledged the review feedback, noting they'll address the peer dependency/README update in the #3208 branch.
|
 [**Koko Da Doll**](https://en.wikipedia.org/wiki/Koko_Da_Doll) (aka _Rasheeda Williams_) was a 35-year-young Black trans woman, performance artist, singer, and star of the acclaimed documentary **Kokomo City**. Born in College Park, Georgia, she was based in Atlanta and became a prominent voice for transgender visibility and the rights of Black trans women. She was a talented rap artist who released two singles: "Trick" (2020) and "Bulletproof" (2022). A song she created was featured on the TV show _The Chi_ in 2023, showcasing her artistic talents beyond her advocacy work. Koko was one of four Black trans women featured in the groundbreaking documentary [**Kokomo City**](https://www.magpictures.com/kokomocity/), directed by D. Smith. The film premiered at the 2023 Sundance Film Festival and won both the NEXT Innovator Award and NEXT Audience Award. It also received the Berlinale Panorama Audience Award. In the film, Koko spoke openly about her experiences as a sex worker and the challenges faced by Black trans women. She discussed doing sex work to avoid homelessness for her mother, sister, and herself. After the Sundance première, Koko wrote on Instagram: > _"I will be the reason there's more opportunities and doors opening for transgender girls."_ She hoped that her participation in the film would help save lives and create more opportunities for young trans women. On April 18, 2023, at around 11pm, Koko Da Doll was found dead with a gunshot wound on a sidewalk near Holmes Shopping Plaza in Southwest Atlanta. She was 35 years old. A 17-year-old suspect was arrested on April 27, 2023, on suspicion of murder, aggravated assault, and possession of a firearm in the commission of a felony. Atlanta police indicated that a hate crime investigation was ongoing. Koko was the 13th trans person killed in the United States in 2023. Following her death, _Kokomo City_ was dedicated to her memory. She was honored during the In Memoriam segment at the 2023 BET Awards. _The New York Times_ described her as someone who _"brims with vitality, ambition, and insight"_ — a woman who fought tooth and nail for her life and self-worth. Her tragic death serves as a stark reminder of the ongoing violence and discrimination faced by trans women in America. [AP News](https://apnews.com/article/koko-da-doll-kokomo-city-killed-transgender-0c02d2c623deffebceaa74912e308609) · [AL.com](https://www.al.com/reckon/2023/07/murdered-kokomo-city-star-koko-da-doll-shares-her-hopes-for-young-trans-girls.html) · [TDoR](https://tdor.translivesmatter.info/reports/2023/04/18/rasheeda-williams_atlanta-georgia-usa_0c3bc39f) ------------------------------- Version 28 drops support for Node.js versions below 22.19.0, adds full Zod 4.4+ compatibility, and makes the Zod plugin an optional peer dependency — you now need to install `@express-zod-api/zod-plugin` manually to keep using `.example()`, `.label()`, and similar methods, while `brand()` is replaced by `.xBrand()` to avoid conflicts with Zod 4.4. Several config properties were renamed for clarity: `wrongMethodBehavior` → `hintAllowedMethods`, `methodLikeRouteBehavior` → `recognizeMethodDependentRoutes`, `shortDescription` → `summary`, and `noContent` → `noBodySchema`. The `hasSummaryFromDescription` boolean was replaced with a more flexible `summarizer` function that lets you customize how endpoint summaries are derived. The automated migration tool has been updated accordingly, now requiring `eslint@^10.0.0` and `typescript-eslint@^8.58.0`. - #3207 - #3242 - #3267 - #3268 - #3287 - #3294 - #3299 - #3300 - #3301 - #3302 - #3303 - #3310 - #3313 - #3334 - #3340 - #3364 (incl. undo of #3357) - #3365 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * v28: public option/metadata renames (shortDescription → summary, wrongMethodBehavior → hintAllowedMethods, methodLikeRouteBehavior → recognizeMethodDependentRoutes, noContent → noBodySchema) and a configurable documentation summarizer. * **Documentation** * CHANGELOG/README/SECURITY updated with v28 notes, summarizer docs, migration examples and migration tool link; README shows Zod plugin as optional and xBrand usage. * **Chores** * Zod plugin moved to optional/peer, branding API renamed (.brand → .xBrand); tooling and Node/module resolution updates. * **Tests** * Test suite updated to align with renames, summarizer, metadata/examples and branding changes. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
1 participant
v8.58 provides the official support of TS 6