Skip to content

br(v28): mv noContent —> noBodySchema#3303

Merged
RobinTail merged 4 commits intomake-v28from
mv-noContent-prop
Apr 6, 2026
Merged

br(v28): mv noContent —> noBodySchema#3303
RobinTail merged 4 commits intomake-v28from
mv-noContent-prop

Conversation

@RobinTail
Copy link
Copy Markdown
Owner

Renaming for clarity

@RobinTail RobinTail added this to the v28 milestone Apr 6, 2026
@RobinTail RobinTail added refactoring The better way to achieve the same result breaking Backward incompatible changes labels Apr 6, 2026
@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented Apr 6, 2026

Reviewed PR #3303 — clean rename of noContent to noBodySchema in the Integration class. Impact analysis confirmed no stale references. Migration rule and tests follow established patterns. Approved with a minor observation about shouldHaveContent terminology.

Task list (4/4 completed)
  • Checkout PR and read diff
  • Read changed files and analyze impact
  • Run impact analysis for renamed identifier
  • Draft and submit review

Pullfrog  | View workflow run | Triggered by Pullfrog | Using Claude Opus𝕏

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 6, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1f3900d2-d30a-452f-8a2e-f94c231dc54e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mv-noContent-prop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no issues found.

The rename is complete with no stale references to noContent outside migration/ and CHANGELOG.md (which correctly reference the old name). The migration rule and its tests follow established patterns. The noContentFactory in example/ is a different concept (HTTP 204 endpoint factory) and is unaffected.

Minor observation: shouldHaveContent in common-helpers.ts still uses "Content" terminology while this PR shifts toward "Body" (noBodySchema, hasBody). Not blocking — renaming that helper would be a broader change touching documentation-helpers.ts and tests.

Pullfrog  | View workflow run | Using Claude Opus𝕏

@coveralls-official
Copy link
Copy Markdown

coveralls-official Bot commented Apr 6, 2026

Coverage Status

coverage: 100.0%. remained the same — mv-noContent-prop into make-v28

Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no issues found. The new commits are cosmetic changelog formatting only.

Pullfrog  | View workflow run | Using Claude Opus𝕏

@RobinTail RobinTail merged commit a25887b into make-v28 Apr 6, 2026
12 checks passed
@RobinTail RobinTail deleted the mv-noContent-prop branch April 6, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Backward incompatible changes refactoring The better way to achieve the same result

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant