Skip to content

chore(v28): Using undici 8#3294

Merged
RobinTail merged 3 commits intomake-v28from
use-undici8
Apr 4, 2026
Merged

chore(v28): Using undici 8#3294
RobinTail merged 3 commits intomake-v28from
use-undici8

Conversation

@RobinTail
Copy link
Copy Markdown
Owner

@RobinTail RobinTail commented Apr 2, 2026

instead of #3293

Requires Node.js 22.19.0 and higher

@RobinTail RobinTail added the dependencies Pull requests that update a dependency file label Apr 2, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 2, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3c806ac7-e24d-410c-b7d2-1f58418eb9b3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch use-undici8

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 2, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedundici@​7.24.7 ⏵ 8.0.0100 +28100100 +198100

View full report

@RobinTail RobinTail marked this pull request as ready for review April 2, 2026 19:44
@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented Apr 2, 2026

Reviewed PR #3294 — no actionable issues. The undici v7→v8 bump and corresponding Node.js ^22.19.0 floor are consistent across all packages, CI, and changelog. The only undici usage (Agent, fetch in tests) is unaffected by v8 breaking changes.

Task list (3/3 completed)
  • Read the PR diff to identify all areas of change
  • Investigate each changed file and trace impact
  • Self-critique drafted comments and submit review

Pullfrog  | View workflow run | Triggered by Pullfrog | Using Claude Opus𝕏

@RobinTail RobinTail added the breaking Backward incompatible changes label Apr 2, 2026
@coveralls-official
Copy link
Copy Markdown

coveralls-official Bot commented Apr 2, 2026

Coverage Status

coverage: 100.0%. remained the same
when pulling 432b453 on use-undici8
into 377fc3e on make-v28.

Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean dependency bump. The only undici usage (Agent, fetch in tests) is unaffected by the v8 breaking changes. Engine constraints, CI matrix, changelog, and lockfile are all consistent.

Pullfrog  | View workflow run | Using Claude Opus𝕏

@RobinTail RobinTail added this to the v28 milestone Apr 3, 2026
@RobinTail RobinTail changed the title Using undici 8 chore(v28): Using undici 8 Apr 3, 2026
This was referenced Apr 3, 2026
@RobinTail RobinTail added the CI/CD label Apr 3, 2026
# Conflicts:
#	pnpm-lock.yaml
@RobinTail RobinTail merged commit a355124 into make-v28 Apr 4, 2026
12 checks passed
@RobinTail RobinTail deleted the use-undici8 branch April 4, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Backward incompatible changes CI/CD dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant