Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Allow deletion of example module #253

Closed
7 tasks done
Rllyyy opened this issue Mar 26, 2023 · 0 comments · Fixed by #252
Closed
7 tasks done

[FEATURE REQ] Allow deletion of example module #253

Rllyyy opened this issue Mar 26, 2023 · 0 comments · Fixed by #252
Assignees
Labels
enhancement New feature or request

Comments

@Rllyyy
Copy link
Owner

Rllyyy commented Mar 26, 2023

To achieve this the example module needs to be added to the localStorage if the user first visits the website.

Caution:

  • A user may not visit the homepage first. For example the documentation directly links to the module as an example for each question type

TODO:

  • Remove limitation to delete module types_1
  • Remove limitation to edit questions of module types_1
  • Remove limitation to delete questions of module types_1
  • Remove limitation to create module types_1 (Although this behaviour is discouraged)
  • Test direct visit to question from external site if the user hasn't been to the website before
  • Test addition of types_1 to localStorage on first visit
  • Test not adding types_1 to localStorage if user deleted the module
@Rllyyy Rllyyy added the enhancement New feature or request label Mar 26, 2023
@Rllyyy Rllyyy self-assigned this Mar 26, 2023
@Rllyyy Rllyyy linked a pull request Mar 26, 2023 that will close this issue
Rllyyy added a commit that referenced this issue Mar 29, 2023
…not updating when using mode random (#148)+:wastebasket:Added ability to delete example module (#253)+:books:Removed edit warnings from README (#255)+:wrench:Added type "edit" | "create" to Question Editor (#251)

* Added state to module on navigation

* refactored context + add type to QuestionEditor

* Added ability to delete question in all modes and orders + Fixed question navigation not showing on mobile + Added delete tests

* Added ability to delete example module (#253)

* fixed answer options mismatching on question edit + fixed flicker to 0

* Checked that all bookmarked questions exist + added tests for params + fixed failing tests + fixed correction not disappearing on deletion, edit and navigation

* Removed edit warnings from README (#255) + renamed context + removed unnecessary props from context
@Rllyyy Rllyyy closed this as completed Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant