Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CODE] Add type ("edit" | "create") to QuestionEditor #251

Closed
Rllyyy opened this issue Mar 25, 2023 · 0 comments · Fixed by #252
Closed

[CODE] Add type ("edit" | "create") to QuestionEditor #251

Rllyyy opened this issue Mar 25, 2023 · 0 comments · Fixed by #252
Assignees
@Rllyyy
Labels
code Code is wrong or could be simplified

Comments

@Rllyyy
Copy link
Owner

Rllyyy commented Mar 25, 2023

Previously, the QuestionEditor Component distinguished between editing and creating a question by checking the optional questionID parameter. However, this method may be logical from an outside perspective.
@Rllyyy Rllyyy added the code Code is wrong or could be simplified label Mar 25, 2023
@Rllyyy Rllyyy self-assigned this Mar 25, 2023
@Rllyyy Rllyyy linked a pull request Mar 25, 2023 that will close this issue
Refactor module context provider #252
Merged
Rllyyy added a commit that referenced this issue Mar 29, 2023
@Rllyyy
♻️Refactored module context provider (#134/#252)+:bug:Fixed question …
cd21971 
…not updating when using mode random (#148)+:wastebasket:Added ability to delete example module (#253)+:books:Removed edit warnings from README (#255)+:wrench:Added type "edit" | "create" to Question Editor (#251)

* Added state to module on navigation

* refactored context + add type to QuestionEditor

* Added ability to delete question in all modes and orders + Fixed question navigation not showing on mobile + Added delete tests

* Added ability to delete example module (#253)

* fixed answer options mismatching on question edit + fixed flicker to 0

* Checked that all bookmarked questions exist + added tests for params + fixed failing tests + fixed correction not disappearing on deletion, edit and navigation

* Removed edit warnings from README (#255) + renamed context + removed unnecessary props from context
@Rllyyy Rllyyy closed this as completed Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rllyyy Rllyyy

Labels
code Code is wrong or could be simplified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor module context provider Rllyyy/repeatio
1 participant
@Rllyyy