Skip to content

Comments

fix(versioning): derive assembly versions from plugin.json#348

Closed
RicherTunes wants to merge 4 commits intomainfrom
fix/versioning-from-plugin-json
Closed

fix(versioning): derive assembly versions from plugin.json#348
RicherTunes wants to merge 4 commits intomainfrom
fix/versioning-from-plugin-json

Conversation

@RicherTunes
Copy link
Owner

Summary

Single source of truth for versioning: all assembly versions now derived from .

Changes

  • Directory.Build.props: Read version from plugin.json at build time
  • Directory.Build.targets: Validate version extraction, fail build if missing
  • Removed: file and (redundant sources)
  • Test: validates 3-version contract

3-Version Contract

All three must match for proper Lidarr plugin loading:

    • CLR binding
    • File properties
    • Lidarr display

Benefits

  • No more version drift between plugin.json and assemblies
  • Build fails fast if plugin.json is malformed
  • Test catches version mismatches before deployment

Test Plan

  • Build succeeds with version from plugin.json
  • AssemblyVersionConsistencyTests pass
  • Deployed plugin shows correct version in Lidarr UI

This pattern can be applied to Qobuzarr and Tidalarr for ecosystem parity.

Generated with Claude Code

@github-actions
Copy link
Contributor

github-actions bot commented Dec 27, 2025

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@RicherTunes
Copy link
Owner Author

Stale — superseded by packaging-gates adoption (#397) and ecosystem standardization.

@RicherTunes RicherTunes closed this Feb 6, 2026
RicherTunes added a commit that referenced this pull request Feb 13, 2026
Bumps ext/Lidarr.Plugin.Common from da58f3e to 805af9f (7 commits):
- fix(ci): include JSON files in Docker host assembly extraction (#350)
- feat(scripts): ext-common-sha.txt format guard + bulk repin tool (#349)
- fix(scripts): improve stale workflow pin warnings (#348)
- docs(scripts): mark --update-pins as manual-only (#347)
- fix(tests): replace Progress<T> with synchronous IProgress<T> (#346)
- fix(scripts): prevent ((UPDATED++)) exit under set -e (#345)
- feat(scripts): single source of truth for Common SHA pins (#344)

Also updates packaging-gates.yml SHA pin to 805af9f — this includes
the JSON extraction fix that should unblock the packaging-gates CI job.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
RicherTunes added a commit that referenced this pull request Feb 13, 2026
Bumps ext/Lidarr.Plugin.Common from da58f3e to 805af9f (7 commits):
- fix(ci): include JSON files in Docker host assembly extraction (#350)
- feat(scripts): ext-common-sha.txt format guard + bulk repin tool (#349)
- fix(scripts): improve stale workflow pin warnings (#348)
- docs(scripts): mark --update-pins as manual-only (#347)
- fix(tests): replace Progress<T> with synchronous IProgress<T> (#346)
- fix(scripts): prevent ((UPDATED++)) exit under set -e (#345)
- feat(scripts): single source of truth for Common SHA pins (#344)

Also updates packaging-gates.yml SHA pin to 805af9f — this includes
the JSON extraction fix that should unblock the packaging-gates CI job.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
RicherTunes added a commit that referenced this pull request Feb 13, 2026
Bumps ext/Lidarr.Plugin.Common from da58f3e to 805af9f (7 commits):
- fix(ci): include JSON files in Docker host assembly extraction (#350)
- feat(scripts): ext-common-sha.txt format guard + bulk repin tool (#349)
- fix(scripts): improve stale workflow pin warnings (#348)
- docs(scripts): mark --update-pins as manual-only (#347)
- fix(tests): replace Progress<T> with synchronous IProgress<T> (#346)
- fix(scripts): prevent ((UPDATED++)) exit under set -e (#345)
- feat(scripts): single source of truth for Common SHA pins (#344)

Also updates packaging-gates.yml SHA pin to 805af9f — this includes
the JSON extraction fix that should unblock the packaging-gates CI job.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant