fix(packaging): don't ship FluentValidation to avoid ImportList Test() type-identity mismatch#346
Merged
RicherTunes merged 3 commits intomainfrom Dec 27, 2025
Merged
Conversation
Aligns assembly version with manifest.json to ensure consistent version reporting in Lidarr logs and diagnostics. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Adds explicit test to prevent regression: FluentValidation.dll must NOT be shipped with the plugin package. The guard test documents why: shipping FluentValidation causes type-identity mismatch across the plugin boundary, breaking the Test(List<ValidationFailure>) override signature. Changes: - Remove FluentValidation.dll from RequiredTypeIdentityAssemblies - Add FluentValidation.dll to ForbiddenAssemblies - Add Package_Must_Not_Ship_FluentValidation() with detailed doc comment 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
RicherTunes
added a commit
that referenced
this pull request
Dec 27, 2025
Adds build-time validation that FluentValidation.dll exists in the Lidarr host assemblies path. This prevents accidental builds where Directory.Packages.props pulls FV 11.x from NuGet instead of using the host's FluentValidation. The guard fails fast with a clear error message explaining: - Why host FV is required (type-identity for Test override) - How to fix it (extract assemblies or use complete installation) - Link to PR #346 for context This closes the "contributor footgun" risk identified during the FluentValidation exclusion fix review. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
RicherTunes
added a commit
that referenced
this pull request
Feb 13, 2026
Bumps ext/Lidarr.Plugin.Common from da58f3e to 805af9f (7 commits): - fix(ci): include JSON files in Docker host assembly extraction (#350) - feat(scripts): ext-common-sha.txt format guard + bulk repin tool (#349) - fix(scripts): improve stale workflow pin warnings (#348) - docs(scripts): mark --update-pins as manual-only (#347) - fix(tests): replace Progress<T> with synchronous IProgress<T> (#346) - fix(scripts): prevent ((UPDATED++)) exit under set -e (#345) - feat(scripts): single source of truth for Common SHA pins (#344) Also updates packaging-gates.yml SHA pin to 805af9f — this includes the JSON extraction fix that should unblock the packaging-gates CI job. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
RicherTunes
added a commit
that referenced
this pull request
Feb 13, 2026
Bumps ext/Lidarr.Plugin.Common from da58f3e to 805af9f (7 commits): - fix(ci): include JSON files in Docker host assembly extraction (#350) - feat(scripts): ext-common-sha.txt format guard + bulk repin tool (#349) - fix(scripts): improve stale workflow pin warnings (#348) - docs(scripts): mark --update-pins as manual-only (#347) - fix(tests): replace Progress<T> with synchronous IProgress<T> (#346) - fix(scripts): prevent ((UPDATED++)) exit under set -e (#345) - feat(scripts): single source of truth for Common SHA pins (#344) Also updates packaging-gates.yml SHA pin to 805af9f — this includes the JSON extraction fix that should unblock the packaging-gates CI job. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
RicherTunes
added a commit
that referenced
this pull request
Feb 13, 2026
Bumps ext/Lidarr.Plugin.Common from da58f3e to 805af9f (7 commits): - fix(ci): include JSON files in Docker host assembly extraction (#350) - feat(scripts): ext-common-sha.txt format guard + bulk repin tool (#349) - fix(scripts): improve stale workflow pin warnings (#348) - docs(scripts): mark --update-pins as manual-only (#347) - fix(tests): replace Progress<T> with synchronous IProgress<T> (#346) - fix(scripts): prevent ((UPDATED++)) exit under set -e (#345) - feat(scripts): single source of truth for Common SHA pins (#344) Also updates packaging-gates.yml SHA pin to 805af9f — this includes the JSON extraction fix that should unblock the packaging-gates CI job. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Lidarr plugin load failure on host ghcr.io/hotio/lidarr:pr-plugins-3.1.1.4884 (Lidarr 3.1.1.4884):\n\nMethod 'Test' in type 'NzbDrone.Core.ImportLists.Brainarr.Brainarr' ... does not have an implementation.\n\nRoot cause: shipping a private FluentValidation.dll causes FluentValidation.Results.ValidationFailure type-identity mismatch across the plugin boundary, so the ImportListBase.Test(List) override no longer matches the host signature at runtime.\n\nChanges:\n- �uild.ps1: remove FluentValidation.dll from the packaged output\n- manifest.json: updated file list/hash accordingly\n\nVerification:\n- Deploy plugin to /config/plugins/RicherTunes/Brainarr/ without FluentValidation.dll\n- Restart Lidarr container\n- GET /api/v1/importlist/schema shows Brainarr\n\nFollow-up (not included): bump Brainarr.Plugin/Properties/AssemblyInfo.cs to match plugin.json version so logs aren’t misleading.