docs: align packaging policy with ecosystem canonical policy#345
Closed
RicherTunes wants to merge 1 commit intomainfrom
Closed
docs: align packaging policy with ecosystem canonical policy#345RicherTunes wants to merge 1 commit intomainfrom
RicherTunes wants to merge 1 commit intomainfrom
Conversation
Update PACKAGING_POLICY_BASELINE.md to reflect the canonical ecosystem policy from Lidarr.Plugin.Common's PluginPackageValidator: - Only Lidarr.Plugin.Abstractions.dll should be shipped separately - FluentValidation.dll, MS.Extensions.*Abstractions.dll are host-provided - Note known discrepancies with current build.ps1/manifest.json 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Owner
Author
|
Closing - the documented policy was incorrect. Working packages (Tidalarr/Qobuzarr) DO ship FluentValidation.dll and MS.Extensions.*Abstractions.dll. The PluginPackageValidator in Common needs to be updated to match reality, not the other way around. |
RicherTunes
added a commit
that referenced
this pull request
Feb 13, 2026
Bumps ext/Lidarr.Plugin.Common from da58f3e to 805af9f (7 commits): - fix(ci): include JSON files in Docker host assembly extraction (#350) - feat(scripts): ext-common-sha.txt format guard + bulk repin tool (#349) - fix(scripts): improve stale workflow pin warnings (#348) - docs(scripts): mark --update-pins as manual-only (#347) - fix(tests): replace Progress<T> with synchronous IProgress<T> (#346) - fix(scripts): prevent ((UPDATED++)) exit under set -e (#345) - feat(scripts): single source of truth for Common SHA pins (#344) Also updates packaging-gates.yml SHA pin to 805af9f — this includes the JSON extraction fix that should unblock the packaging-gates CI job. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
RicherTunes
added a commit
that referenced
this pull request
Feb 13, 2026
Bumps ext/Lidarr.Plugin.Common from da58f3e to 805af9f (7 commits): - fix(ci): include JSON files in Docker host assembly extraction (#350) - feat(scripts): ext-common-sha.txt format guard + bulk repin tool (#349) - fix(scripts): improve stale workflow pin warnings (#348) - docs(scripts): mark --update-pins as manual-only (#347) - fix(tests): replace Progress<T> with synchronous IProgress<T> (#346) - fix(scripts): prevent ((UPDATED++)) exit under set -e (#345) - feat(scripts): single source of truth for Common SHA pins (#344) Also updates packaging-gates.yml SHA pin to 805af9f — this includes the JSON extraction fix that should unblock the packaging-gates CI job. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
RicherTunes
added a commit
that referenced
this pull request
Feb 13, 2026
Bumps ext/Lidarr.Plugin.Common from da58f3e to 805af9f (7 commits): - fix(ci): include JSON files in Docker host assembly extraction (#350) - feat(scripts): ext-common-sha.txt format guard + bulk repin tool (#349) - fix(scripts): improve stale workflow pin warnings (#348) - docs(scripts): mark --update-pins as manual-only (#347) - fix(tests): replace Progress<T> with synchronous IProgress<T> (#346) - fix(scripts): prevent ((UPDATED++)) exit under set -e (#345) - feat(scripts): single source of truth for Common SHA pins (#344) Also updates packaging-gates.yml SHA pin to 805af9f — this includes the JSON extraction fix that should unblock the packaging-gates CI job. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
PACKAGING_POLICY_BASELINE.mdto reflect the canonical ecosystem policy fromLidarr.Plugin.Common/tests/PackageValidation/PluginPackageValidator.cs:Lidarr.Plugin.Abstractions.dll(host image doesn't ship it)FluentValidation.dll,MS.Extensions.*Abstractions.dll(host provides, shipping causes type-identity conflicts)Known Discrepancies
The current
build.ps1andmanifest.jsonstill include FluentValidation.dll and MS.Extensions.*Abstractions.dll in the package. A follow-up PR will address aligning the actual build with this policy.Context
This is part of the ecosystem packaging policy investigation following the Common library submodule bump. See:
🤖 Generated with Claude Code