-
-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch selection change performance #3673
Conversation
Does this not close #3660 ? If this addresses the other points but not the input remap registering, I think it's still fine to mark this as closing that issue. |
Lag is still observable although better than before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I playtested and didn't see any glaring bugs with this and the patch change performance was definitely better. Code's now also been hammered into shape.
Brief Description of What This PR Does
Increased performance when changing shown patch.
Related Issues
Closes #3660
Closes #3674
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.