Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch selection change performance #3673

Merged
merged 16 commits into from
Aug 11, 2022
Merged

Conversation

84634E1A607A
Copy link
Contributor

@84634E1A607A 84634E1A607A commented Aug 9, 2022

Brief Description of What This PR Does

Increased performance when changing shown patch.

Related Issues
Closes #3660
Closes #3674

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@hhyyrylainen hhyyrylainen added this to the Release 0.5.10 milestone Aug 9, 2022
@hhyyrylainen hhyyrylainen requested review from a team and athariqk August 9, 2022 06:49
@hhyyrylainen
Copy link
Member

Does this not close #3660 ? If this addresses the other points but not the input remap registering, I think it's still fine to mark this as closing that issue.

@84634E1A607A
Copy link
Contributor Author

Lag is still observable although better than before.

@hhyyrylainen
Copy link
Member

Is the lag caused by #1085 ? If so I think #3660 could be closed.

@84634E1A607A
Copy link
Contributor Author

84634E1A607A commented Aug 9, 2022

Caused by #3674 (It hits me that #3660 can be closed)

Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I playtested and didn't see any glaring bugs with this and the patch change performance was definitely better. Code's now also been hammered into shape.

@hhyyrylainen hhyyrylainen merged commit 19921f3 into master Aug 11, 2022
@hhyyrylainen hhyyrylainen deleted the patch_change_performance branch August 11, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve LineChart tooltip performance Improve performance when changing shown patch on the report tab
2 participants