Improve performance when changing shown patch on the report tab

[hhyyrylainen]

With a bunch of data that causes quite big lag spikes. In our code the biggest things seem to be #3659 as well as:

and:

I think ultimately the biggest performance thing is how many Godot objects get destroyed and recreated each time. I think instead we'll need to either cache the timeline display objects and update them or make bigger rich text blocks to have fewer overall objects.

[hhyyrylainen]

I set this as high priority as the lag is experienced much more often with: #3658

[84634E1A607A]

we'll need to either cache the timeline display object

Thrive/src/microbe_stage/editor/TimelineTab.cs

Line 76 in 0f74a72

eventsContainer.FreeChildren();

We can split eventsContainer into globalEventsContainer and localEventsContainer so that only local events will be updated; and custom rich text label count can be reduced.

[hhyyrylainen]

We can split eventsContainer into globalEventsContainer and localEventsContainer

That sounds like a pretty simple change with the potential to improve performance a lot.

[84634E1A607A]

Thrive/src/gui_common/tooltip/ToolTipManager.cs

Line 373 in 0f74a72

private Control? GetGroup(string name, bool verbose = true)

This uses plain search. Dictionary / Binary search will improve performance a lot. (First Pic, 0.42%)

Plus, a great fraction of time in ClearChart should also be spent here.

[84634E1A607A]

Thrive/src/gui_common/charts/line/LineChart.cs

Line 696 in 0f74a72

dataLine.InterpolatePointPosition(

Skip animation (or even entire draw) if line is not drawn.

[84634E1A607A]

On master (timeline tab not yet involves) (Sorry that's move to patch)

[hhyyrylainen]

Moving to a patch has always had a lag spike, mostly due to: #1085

[84634E1A607A]

src/microbe_stage/editor/MicrobeEditorReportComponent.cs UpdatePatchDetails called twice.