Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show shared rank in global listing #1328

Merged
merged 2 commits into from
Feb 4, 2023

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Jan 22, 2023

https://discord.com/channels/310192285306454017/645777658319208448/1065718996697096284

The rank shown in the list was just the row number and didsn't account for when multiple users had the same score. I've updated the logic to account for that.

image

@EmoonX
Copy link
Contributor

EmoonX commented Jan 22, 2023

Perhaps we can also use ordering tiers? Just my two cents, as it barely makes a difference most of the time.

Something like:

  1. Points
  2. # of masteries/completions
  3. Retro points (if hardcore ranking)
  4. # of achievements

So list is ordered first based on whatever the user chooses and then tier by tier. Finally, if everything is still tied, rank is shared.

@luchaos luchaos merged commit 4c021fb into RetroAchievements:master Feb 4, 2023
@luchaos
Copy link
Member

luchaos commented Feb 4, 2023

Perhaps we can also use ordering tiers? Just my two cents, as it barely makes a difference most of the time.
So list is ordered first based on whatever the user chooses and then tier by tier. Finally, if everything is still tied, rank is shared.

Good input - maintaining the point rankings will undergo an overhaul as soon as the database layer has been revamped. We can revisit your suggestion then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants